Improve error when optional subdoc dependency is missing - #665
Open
ahmetmusab42-stack wants to merge 1 commit into
Open
Improve error when optional subdoc dependency is missing#665ahmetmusab42-stack wants to merge 1 commit into
ahmetmusab42-stack wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docxcomposeis intentionally optional, but callingnew_subdoc()without thesubdocextra currently exposes a raw import traceback. This adds a focused diagnostic at that API boundary:Only a missing top-level
docxcomposemodule is translated. Any unrelatedModuleNotFoundErrorraised while importing the optional implementation is preserved unchanged, so broken or incompatible installations are not misreported.This follows the small guard direction proposed by @janmarsino98 in #629 and addresses the confusing missing-extra diagnostic reported there. It does not make
docxcomposemandatory or restore the pre-0.20.2 dependency behavior.Verification