Port to GTK4 - #29
Draft
danirabbit wants to merge 8 commits into
Draft
Conversation
|
Are there any other PRs relating to this that need to be looked at before this is ready for review? |
Member
Author
|
@zeebok i don't think there are any more prep PRs. I just need to set aside some time to finish it :) |
ryonakano
reviewed
Jul 28, 2026
| delete_event.connect (() => { | ||
| close_request.connect (() => { | ||
| if (transfer.status == "active") { | ||
| return hide_on_delete (); |
Member
| delete_event.connect (() => { | ||
| close_request.connect (() => { | ||
| if (transfer.status == "active") { | ||
| return hide_on_delete (); |
Member
There was a problem hiding this comment.
Suggested change
| return hide_on_delete (); | |
| hide (); | |
| return true; |
Same here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8