Skip to content

Icons: add media-playlist-repeat-disabled - #1114

Merged
danirabbit merged 2 commits into
elementary:mainfrom
City-busz:repeat-disabled-icon
Nov 4, 2026
Merged

danirabbit merged 2 commits into
elementary:mainfrom
City-busz:repeat-disabled-icon

Conversation

@City-busz
City-busz requested a review from a team November 4, 2026 21:59
@City-busz
City-busz force-pushed the repeat-disabled-icon branch 3 times, most recently from 9a1c502 to d950aa0 Compare November 4, 2026 22:12
Comment thread lib/Icons/scalable/meson.build Outdated
Comment on lines +19 to +20
['media-playlist-repeat-disabled-symbolic-rtl', 'media-playlist-no-repeat-symbolic-rtl'],
['media-playlist-repeat-disabled-symbolic', 'media-playlist-no-repeat-symbolic']

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about symlinking here. Good opportunity to just fix things to use a single name?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it seems to be reasonable. I removed the symlinks, and sent pull requests for the affected applications:

@danirabbit

Copy link
Copy Markdown
Member

Thanks! We eventually have to move all -symbolic icons to Granite since they're all out of spec, so this makes sense. I'm not sure symlinking is necessary though. We should probably fix apps to use the same name so we don't have to do that

@City-busz
City-busz force-pushed the repeat-disabled-icon branch from d950aa0 to acbe30d Compare November 4, 2026 22:34
@City-busz City-busz changed the title Icons: add media-playlist-repeat-disabled and symlink Icons: add media-playlist-repeat-disabled Nov 4, 2026
@City-busz
City-busz requested a review from danirabbit November 4, 2026 22:36

@danirabbit danirabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@danirabbit
danirabbit enabled auto-merge (squash) November 4, 2026 23:13
@danirabbit
danirabbit merged commit aaaf0fc into elementary:main Nov 4, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants