Conversation
Member
|
this looks fine, although we probably don't need to land it until/unless we decide to take the dependence for external developers |
juj
reviewed
Jun 2, 2026
juj
reviewed
Jun 2, 2026
sbc100
force-pushed
the
add_ninja
branch
3 times, most recently
from
July 21, 2026 16:12
93c3184 to
4dad58a
Compare
We may start using it internally in emscripten. See emscripten-core/emscripten#17809
sbc100
disabled auto-merge
July 21, 2026 16:14
sbc100
added a commit
that referenced
this pull request
Jul 21, 2026
Now that we have ninja binaries available for install (See #1105), I don't think we need to be able to build it from source anymore. We can treat ninja more like node and/or python and just depend on the binary version of it.
Member
|
So is the plan to just switch to depending on ninja to build the libraries, and delete all the python that does the same thing? |
Collaborator
Author
|
Yes, see #1742 |
sbc100
added a commit
that referenced
this pull request
Jul 21, 2026
…ource When building tools from source, unconditionally use the Ninja generator. This massively simplifies the Windows build process allowing for the removal of `--vs2019`, `--vs2022`, `--mingw` and `--generator` flags along with `vswhere` detection, Visual Studio multi-config output paths, and the `mingw` SDK package. Instead can now rely on MSCV being configured in the environment prior to running emsdk, and since #1105 landed ninja is also always available via emsdk. See: #1734
sbc100
added a commit
that referenced
this pull request
Jul 21, 2026
…ource When building tools from source, unconditionally use the Ninja generator. This massively simplifies the Windows build process allowing for the removal of `--vs2019`, `--vs2022`, `--mingw` and `--generator` flags along with `vswhere` detection, Visual Studio multi-config output paths, and the `mingw` SDK package. Instead can now rely on MSCV being configured in the environment prior to running emsdk, and since #1105 landed ninja is also always available via emsdk. See: #1734
sbc100
added a commit
that referenced
this pull request
Jul 21, 2026
…ource When building tools from source, unconditionally use the Ninja generator. This massively simplifies the Windows build process allowing for the removal of `--vs2019`, `--vs2022`, `--mingw` and `--generator` flags along with `vswhere` detection, Visual Studio multi-config output paths, and the `mingw` SDK package. Instead can now rely on MSCV being configured in the environment prior to running emsdk, and since #1105 landed ninja is also always available via emsdk. See: #1734
sbc100
added a commit
that referenced
this pull request
Jul 21, 2026
…ource When building tools from source, unconditionally use the Ninja generator. This massively simplifies the Windows build process allowing for the removal of `--vs2019`, `--vs2022`, `--mingw` and `--generator` flags along with `vswhere` detection, Visual Studio multi-config output paths, and the `mingw` SDK package. Instead can now rely on MSCV being configured in the environment prior to running emsdk, and since #1105 landed ninja is also always available via emsdk. See: #1734
sbc100
added a commit
that referenced
this pull request
Jul 21, 2026
…ource When building tools from source, unconditionally use the Ninja generator. This massively simplifies the Windows build process allowing for the removal of `--vs2019`, `--vs2022`, `--mingw` and `--generator` flags along with `vswhere` detection, Visual Studio multi-config output paths, and the `mingw` SDK package. Instead can now rely on MSCV being configured in the environment prior to running emsdk, and since #1105 landed ninja is also always available via emsdk. See: #1734
sbc100
added a commit
that referenced
this pull request
Jul 21, 2026
…ource When building tools from source, unconditionally use the Ninja generator. This massively simplifies the Windows build process allowing for the removal of `--vs2019`, `--vs2022`, `--mingw` and `--generator` flags along with `vswhere` detection, Visual Studio multi-config output paths, and the `mingw` SDK package. Instead can now rely on MSCV being configured in the environment prior to running emsdk, and since #1105 landed ninja is also always available via emsdk. See: #1734
sbc100
added a commit
that referenced
this pull request
Jul 27, 2026
…ource When building tools from source, unconditionally use the Ninja generator. This massively simplifies the Windows build process allowing for the removal of `--vs2019`, `--vs2022`, `--mingw` and `--generator` flags along with `vswhere` detection, Visual Studio multi-config output paths, and the `mingw` SDK package. Instead can now rely on MSCV being configured in the environment prior to running emsdk, and since #1105 landed ninja is also always available via emsdk. See: #1734
sbc100
added a commit
that referenced
this pull request
Jul 27, 2026
Now that we have ninja binaries available for install (See #1105), I don't think we need to be able to build it from source anymore. We can treat ninja more like node and/or python and just depend on the binary version of it.
sbc100
added a commit
that referenced
this pull request
Aug 4, 2026
Now that we have ninja binaries available for install (See #1105), I don't think we need to be able to build it from source anymore. We can treat ninja more like node and/or python and just depend on the binary version of it.
sbc100
added a commit
that referenced
this pull request
Aug 4, 2026
Now that we have ninja binaries available for install (See #1105), I don't think we need to be able to build it from source anymore. We can treat ninja more like node and/or python and just depend on the binary version of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We may start using it internally in emscripten. See emscripten-core/emscripten#17809
Its also useful to be able to install it when building other things from source (See #1736)