[WIP] Fix environment constructing in MSYS2 shell - #1191
Closed
Blackhex wants to merge 1 commit into
Closed
Conversation
Blackhex
force-pushed
the
fix-msys2-construct-env
branch
from
February 26, 2023 19:56
6d904fb to
a9062ba
Compare
Blackhex
marked this pull request as draft
February 26, 2023 20:04
Blackhex
changed the title
Collaborator
|
I'm going through old PRs. It seems like this could still be useful but we really lack a good test setup for MSYS2 I think. |
Contributor
Author
|
Feel free to take over. I am no longer working on the project. We were running the MSYS2 based CI in this fork https://github.com/Windows-on-ARM-Experiments/emsdk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix,
source `emsdk.py construct_env`or.\emsdk_env.shcorruptsPATHby remving the default system paths.