Cel shading shader: Switch to regular shader parameters#2163
Closed
manuq wants to merge 1 commit into
Closed
Conversation
|
Test build no longer available. |
Collaborator
Author
|
I had to refresh in my mind what I was attempting here. It seems to work now, I will clean and put it for review tomorrow! |
manuq
force-pushed
the
townies-material
branch
3 times, most recently
from
89bedfa to
86b9852
Compare
Collaborator
Author
|
Ready for review. This one was tricky, but is a first step towards a more generic palette swap (hair, clothes). |
Do not rely on instance shader parameters for recoloring. Instead, make the material unique when a different recolor is needed. For instance, by duplicating the cel_shading_recolor_material.tres. Now the way to have the same recoloring in multiple sprites is to share the same material. Townie: have a duplicate copy of the cel shading recolor material. Apply it to all the parts.
wjt
reviewed
May 19, 2026
| @@ -1,9 +1,10 @@ | |||
| [gd_scene format=3 uid="uid://dgrrudegturnw"] | |||
|
|
|||
| [ext_resource type="Material" uid="uid://b7kf0suo0sc7k" path="res://scenes/game_elements/components/cel_shading_recolor_material.tres" id="1_nj51j"] | |||
Member
There was a problem hiding this comment.
This is still set as the material property on the root node. I'm a little confused with how this interacts with the shader_material custom property.
Member
There was a problem hiding this comment.
In #2143 we removed both the material from the root node, and the shader_material from the character randomizer script.
Member
|
Merged as part of #2143. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not rely on instance shader parameters for recoloring. Instead, make the material unique when a different recolor is needed. For instance, by duplicating the cel_shading_recolor_material.tres.