Repository navigation
Log filtered command name - #1631
Merged
Merged
Conversation
If a command is blocked by a cmdfilter, the name of the command should be logged instead of logged as "None".
Returning cmd and args is not used by anything but for logging purposes.
Contributor
|
@jcfrt Thank you! |
Contributor
|
As an example, this is what the before and after look like |
sijis
added a commit
to sijis/errbot
that referenced
this pull request
Jun 6, 2026
* Log filtered command name If a command is blocked by a cmdfilter, the name of the command should be logged instead of logged as "None". * Update cmdfilter docstring Returning cmd and args is not used by anything but for logging purposes. * test: add tests to validate logging of cmdfilter * docs: add info to CHANGES --------- Co-authored-by: Sijis Aviles <sijis.aviles@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a command is blocked by a cmdfilter, the name of the command should be logged instead of being logged as "None".