Version 10.0.0-beta05 - #2486
Open
demolaf wants to merge 41 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the FirebaseUI Auth library's navigation to Navigation 3, introducing serializable back-stack keys to persist state across configuration changes and process death. It also refactors the reauthentication flow to support custom UIs and MFA challenges, removes recovery codes from MFA enrollment, and adds stable test tags to all screens for automated testing. All review comments were filtered out as they pertained to non-code date changes, so I have no further feedback to provide.
demolaf
marked this pull request as draft
September 7, 2026 12:15
This was referenced Sep 7, 2026
Merged
…tion that owns it (#2454) * refactor(auth): let the phone screen own its verification loading state * fix(auth): read auth state per authUI instance when clearing loading on dispose
…lot (#2452) * feat(auth): reshape reauthContent into a ReauthContentState content slot * fix(auth): address reauth review findings and retain state across recreation * refactor(auth): make reauthentication a request-scoped state machine * fix(auth): keep a proved reauthentication alive when its operation signs out * fix(auth): tear down phone verification when a reauthentication attempt fails * test(auth): cover sign-out-during-retry and phone reauth failure end to end * test(auth): drop the flaky phone reauth e2e case
…lment (#2462) * test(auth): pin onComplete and factor refresh on successful MFA enrollment * test(auth): pin the SMS MFA enrollment route through send, verify and resend * test(auth): pin the missing TOTP secret guard and the resend's clean enroll
…slot's sheet chrome (#2476) * test(auth): cover the three recoveries that write a value through to the step they move to * test(auth): assert a custom reauth slot's email and phone steps stay inside the library sheet
…and a screen-scoped phase holder
… FirebaseAuthUI singleton
… a stale composition value
… of returning quietly
…ad of calling it arming
…tead of the shared state flow
…not just skips the retry
demolaf
force-pushed
the
version-10.0.0-beta05
branch
from
September 7, 2026 12:25
5d227bf to
2d959d6
Compare
demolaf
marked this pull request as ready for review
September 7, 2026 15:23
…ign-in provider (#2483)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes