Skip to content

Version 10.0.0-beta05 - #2486

Open
demolaf wants to merge 41 commits into
masterfrom
version-10.0.0-beta05
Open

Version 10.0.0-beta05#2486
demolaf wants to merge 41 commits into
masterfrom
version-10.0.0-beta05

Conversation

@demolaf

@demolaf demolaf commented Sep 7, 2026

Copy link
Copy Markdown
Member

⚠️ Breaking Changes

Changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the FirebaseUI Auth library's navigation to Navigation 3, introducing serializable back-stack keys to persist state across configuration changes and process death. It also refactors the reauthentication flow to support custom UIs and MFA challenges, removes recovery codes from MFA enrollment, and adds stable test tags to all screens for automated testing. All review comments were filtered out as they pertained to non-code date changes, so I have no further feedback to provide.

demolaf and others added 23 commits September 7, 2026 13:25
…tion that owns it (#2454)

* refactor(auth): let the phone screen own its verification loading state

* fix(auth): read auth state per authUI instance when clearing loading on dispose
…eption fallback exhausts

(cherry picked from commit 6fa4f00)
(cherry picked from commit aca99e7)
(cherry picked from commit 8784b13ce29739ed7785aab9ab6fe4faad2a2981)
…data

(cherry picked from commit 8eca4fa)
(cherry picked from commit ac61312)
(cherry picked from commit 126ba985660ff272dbfda427b644ad4fb1ca6197)
…loop

(cherry picked from commit a87cfe3)
(cherry picked from commit 3f4ae70)
(cherry picked from commit 1f1ada380039ed5e7476dfc2e38a683e6edb4549)
…lot (#2452)

* feat(auth): reshape reauthContent into a ReauthContentState content slot

* fix(auth): address reauth review findings and retain state across recreation

* refactor(auth): make reauthentication a request-scoped state machine

* fix(auth): keep a proved reauthentication alive when its operation signs out

* fix(auth): tear down phone verification when a reauthentication attempt fails

* test(auth): cover sign-out-during-retry and phone reauth failure end to end

* test(auth): drop the flaky phone reauth e2e case
…lment (#2462)

* test(auth): pin onComplete and factor refresh on successful MFA enrollment

* test(auth): pin the SMS MFA enrollment route through send, verify and resend

* test(auth): pin the missing TOTP secret guard and the resend's clean enroll
…slot's sheet chrome (#2476)

* test(auth): cover the three recoveries that write a value through to the step they move to

* test(auth): assert a custom reauth slot's email and phone steps stay inside the library sheet
@demolaf
demolaf force-pushed the version-10.0.0-beta05 branch from 5d227bf to 2d959d6 Compare September 7, 2026 12:25
@demolaf
demolaf marked this pull request as ready for review September 7, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant