fix(functions): make the v2 callable handlers actually work 7352ce2 fix(functions): hand addNumbers/addMessage the whole v2 request 8f85835 fix(functions): put back the sanitizer call and the admin imports

[rootkiller6788]

The Cloud Functions sample for the callable-functions quickstart has been dead since #1701 moved it to the v2 imports. That pass swapped the require to firebase-functions/v2/https but left the handler in the v1 shape, so addNumbers was reading firstNumber off the CallableRequest wrapper and answering invalid-argument for every call. TestAddNumber in the androidTest sources waits 60s for "48" and would never see it.

The same pass also dropped const admin = require('firebase-admin') while addMessage still called admin.database(), and turned sanitizer.sanitizeText(text) into a bare sanitizeText(text) that is not defined in the file. addMessage therefore threw a ReferenceError before it ever reached the database write, so it had never written a single message.

I moved the handlers to the single request argument, switched to the modular admin entry points (firebase-admin/database, firebase-admin/messaging) to match the initializeApp import that is already there, and restored the qualified sanitizer call.

How I checked it: no Android SDK on this box, so I installed the exact versions pinned in package-lock.json (firebase-functions 6.1.0, firebase-admin 12.7.0) and drove the real handlers through a small harness, faking only the network boundary (RTDB/FCM/initializeApp). Before: addNumbers threw invalid-argument and addMessage threw ReferenceError: sanitizeText is not defined, then ReferenceError: admin is not defined once the qualifier was back. After: 13 checks pass, including 32 + 16 = 48, the author fields coming off the auth token, the two validation errors, and the push path with and without an instance ID token.

CI does not catch this because the workflow only runs assemble; it never deploys the functions or runs the androidTest.

One unrelated thing I noticed but did not touch: capitalize-sentence: ^0.1.2 in functions/functions/package.json cannot be installed right now. The registry only has 1.0.0, and the 0.1.5 pinned in package-lock.json 404s, so npm install/npm ci fails for that folder before anything else runs. Probably worth a separate dependency bump.

[gemini-code-assist]

Code Review

This pull request migrates Firebase Cloud Functions from v1 to v2, updating the onCall handlers to accept a single request parameter and replacing deprecated admin SDK calls with modular Firebase Admin SDK imports. Feedback on these changes highlights a critical issue where request.instanceIdToken is no longer available directly in v2 and must be retrieved from the raw request headers. Additionally, it is recommended to use optional chaining when accessing properties on request.data to prevent potential runtime TypeError crashes when functions are invoked with empty payloads.