Repository navigation
add quick start app for system isntructions - #2846
Open
VinayGuthal wants to merge 5 commits into
Open
VinayGuthal wants to merge 5 commits into
VinayGuthal wants to merge 5 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new 'Hybrid System Instructions' test screen and view model to the Firebase AI Quickstart app, integrating it into the main navigation and updating Firebase dependency versions. Feedback on these changes highlights a compilation error in SystemInstructionViewModel where update is called on a read-only StateFlow, which should be resolved using a private backing property. Other recommendations include managing coroutine jobs to prevent race conditions, decoupling the ViewModel from MainActivity's static image reference, using rememberSaveable to preserve UI state during configuration changes, avoiding double-bang (!!) operators, and ensuring fallback error messages are provided.
…i/feature/hybrid/SystemInstructionViewModel.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…i/feature/hybrid/SystemInstructionViewModel.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…i/ui/SystemInstructionScreen.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
VinayGuthal
added a commit
to firebase/firebase-android-sdk
that referenced
this pull request
Oct 6, 2026
Adds support for `systemInstruction` when generating content using on-device and hybrid inference modes. ### Summary of Changes - **`firebase-ai-ondevice-interop`**: Added an optional `systemInstruction: TextPart?` property to `GenerateContentRequest` and updated `api.txt`. - **`firebase-ai-ondevice`**: Updated `GenerateContentRequest.toMlKit()` in `Converters.kt` to convert the interop `TextPart` into an ML Kit `SystemInstruction`. - **`firebase-ai`**: - Passed `systemInstruction` from `GenerativeModel.Builder` to `OnDeviceGenerativeModelProvider`. - Updated `OnDeviceGenerativeModelProvider` to validate that `systemInstruction` contains only text parts (throwing `FirebaseAIOnDeviceInvalidRequestException` for non-text parts), concatenate multiple `TextPart` instances with a newline, and attach it to the on-device request. - **Tests & Changelogs**: Added unit tests in `ConvertersTest`, `GenerativeModelBuilderTests`, and `OnDeviceGenerativeModelProviderTests`, and updated `CHANGELOG.md` across all three modules. Tested updating the quickstart app to add testing functionality for system instruction at firebase/quickstart-android#2846
rlazo
approved these changes
Oct 6, 2026
rlazo
left a comment
rlazo
left a comment
Contributor
There was a problem hiding this comment.
Approved.
Hold submitting it until the SDK 06 is out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for system instructions in quickstart application.