Make withSize use a wrapper element so that it can stop calling findDOMNode#5988
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5988 +/- ##
==========================================
+ Coverage 83.77% 83.79% +0.01%
==========================================
Files 329 329
Lines 34423 34546 +123
Branches 9627 9662 +35
==========================================
+ Hits 28839 28948 +109
- Misses 5155 5169 +14
Partials 429 429 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EmptyThreadIndicator and Timeline tests mocked findDOMNode to inject sizes for the WithSize HOC. After WithSize stopped calling findDOMNode, those mocks became no-ops: EmptyThreadIndicator snapshots regressed to zero-width indicators, and Timeline's per-describe override silently fell back to the file-level autoMockElementSize. Switch EmptyThreadIndicator to autoMockElementSize so its snapshots again reflect the 100px container, and drop Timeline's dead override.
Member
|
@fatadel could you put some example profiles? |
Contributor
Oh sorry, forgot. Sure, done ✅ |
Merged
canova
added a commit
that referenced
this pull request
May 26, 2026
Changes: [fatadel] Remove unused dependencies from package.json (#6010) [Nazım Can Altınova] Make profiler-cli work in sandboxed environments (#6003) [Markus Stange] Make profiler-edit run profile compacting before writing out the file (#6015) [Markus Stange] Migrate from prettier to oxfmt (#5986) [Markus Stange] Add a --symbolicate-wasm arg to profiler-edit. (#6008) [Markus Stange] Build and upload the cli artifact in PRs (#6020) [Markus Stange] Use @streamparser/json if the input is too large to fit in a V8 string (#6016) [Nazım Can Altınova] Print also the status output right after cli `load` command (#6019) [Nicolas Chevobbe] Update devtools-reps to 0.27.7 (#6030) [Nazım Can Altınova] Include `--search` option in `pq filter push` (#6026) [Nazım Can Altınova] Update all Yarn dependencies (2026-05-20) (#6033) [fatadel] Translate URL track-index state through profile sanitization (#6000) [Markus Stange] Make withSize use a wrapper element so that it can stop calling findDOMNode (#5988) [Markus Stange] Fix dhat importer (#6036) [Nazım Can Altınova] Annotate inlined frames in CLI call trees and stacks (#6041) [Nazım Can Altınova] Use proper types in cli tests instead of custom inline types (#6038) [Nazım Can Altınova] Fix text truncation for frames named after Object.prototype methods (#6044) [Nazım Can Altınova] Add missing key props to CodeErrorOverlay error list items (#6047) [depfu[bot]] ⬆️ Update oxfmt to version 0.51.0 (#6054) [Nazım Can Altınova] 🔃 Sync: l10n -> main (May 26, 2026) (#6058) [Nazım Can Altınova] Use URL-state symbol server for `profiler-cli function annotate` (#6051) [Nazım Can Altınova] Bump profiler-cli version to 0.2.0 (#6059) And special thanks to our localizers: fr: YD sr: Марко Костић (Marko Kostić) tr: Ali Demirtaş zh-CN: Olvcpr423 zh-CN: wxie
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findDOMNodeis deprecated in React 18 and removed in React 19 strict mode. ThewithSizeHOC was the last in-tree caller.This PR makes
withSizerender a<div style="display: contents">wrapper around the wrapped component and observewrapper.firstElementChildvia the existingResizeObserverwrapper, removing the need forfindDOMNode. The HOC is also converted to a function component usinguseState+useRef+useEffect.The docstring previously claimed the size only updates on window resize; that hasn't been true since the HOC moved to
ResizeObserver, so it's been corrected to "whenever the element's size changes".Test fixes
EmptyThreadIndicator.test.tsxandTimeline.test.tsxwere mockingfindDOMNodeto inject sizes into the wrapped component. WithfindDOMNodegone those mocks silently became no-ops —EmptyThreadIndicatorsnapshots showed zero-width indicators andTimeline's per-describe override fell back to the file-levelautoMockElementSize. The second commit replaces the mocks withautoMockElementSize, restoring the previous size assertions.Snapshot deltas
Every snapshot covering a
withSize-wrapped component now includes the new<div style="display: contents">wrapper. The only width/height changes are inEmptyThreadIndicator.test.tsx.snap(still 30/10/20px after the mock fix).Example profiles
No visual regressions detected from my side.
Profile 1: Before / After
Profile 2: Before / After