Skip to content

More additions to profiler-edit, for sp3 profiles#6009

Open
mstange wants to merge 4 commits into
firefox-devtools:mainfrom
mstange:sp3-profiler-edit-features
Open

More additions to profiler-edit, for sp3 profiles#6009
mstange wants to merge 4 commits into
firefox-devtools:mainfrom
mstange:sp3-profiler-edit-features

Conversation

@mstange
Copy link
Copy Markdown
Contributor

@mstange mstange commented May 8, 2026

This makes it so that you can run profiler-edit with --insert-label-frames browser_labels.toml --only-keep-threads-with-markers-matching='-async,-sync' --merge-non-overlapping-threads-by-name --set-name 'Sp3 5x (with labels, combined main threads)' to turn https://share.firefox.dev/4cXQFED into https://share.firefox.dev/4ezEcsa

The label frames are useful in the JS-only view when applied to profiles from samply; they let us group work like "Paint" and "JS Parsing" (example toml). You can best see them in action in the function list deploy preview: JS-only, ordered by self, with the Self wing showing where the time is spent.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 9.09091% with 140 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.37%. Comparing base (2cb282f) to head (e496d7c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/profile-logic/merge-compare.ts 4.90% 97 Missing ⚠️
src/profile-logic/marker-data.ts 0.00% 28 Missing ⚠️
src/node-tools/profiler-edit.ts 37.50% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6009      +/-   ##
==========================================
- Coverage   83.69%   83.37%   -0.32%     
==========================================
  Files         338      338              
  Lines       35693    35846     +153     
  Branches     9904     9940      +36     
==========================================
+ Hits        29873    29887      +14     
- Misses       5392     5531     +139     
  Partials      428      428              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mstange mstange force-pushed the sp3-profiler-edit-features branch from fd67c9e to f5ac119 Compare June 4, 2026 19:13
@mstange mstange marked this pull request as ready for review June 4, 2026 19:13
@mstange mstange force-pushed the sp3-profiler-edit-features branch from f5ac119 to 33ec551 Compare June 4, 2026 19:20
@mstange mstange marked this pull request as draft June 4, 2026 19:21
@mstange mstange force-pushed the sp3-profiler-edit-features branch from 33ec551 to 508ee02 Compare June 4, 2026 19:38
@mstange mstange force-pushed the sp3-profiler-edit-features branch from 508ee02 to 9d9f405 Compare June 4, 2026 20:03
@mstange mstange marked this pull request as ready for review June 4, 2026 20:03
@mstange mstange requested a review from canova June 4, 2026 20:03
@mstange mstange force-pushed the sp3-profiler-edit-features branch from 9d9f405 to e496d7c Compare June 4, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant