Skip to content

Include --search option in pq filter push#6026

Merged
canova merged 2 commits into
firefox-devtools:mainfrom
canova:pq-filter-search
May 19, 2026
Merged

Include --search option in pq filter push#6026
canova merged 2 commits into
firefox-devtools:mainfrom
canova:pq-filter-search

Conversation

@canova
Copy link
Copy Markdown
Member

@canova canova commented May 15, 2026

This fixes commands like:

pq filter push --during-marker --search Paint

This was already possible to do this with ephemeral filters like

pq thread samples --during-marker --search Paint

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.77%. Comparing base (41473d3) to head (d0bf9c8).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6026    +/-   ##
========================================
  Coverage   83.77%   83.77%            
========================================
  Files         329      329            
  Lines       34423    34423            
  Branches     9627     9523   -104     
========================================
  Hits        28839    28839            
  Misses       5155     5155            
  Partials      429      429            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@canova canova requested review from fatadel and mstange May 15, 2026 15:26
@canova canova force-pushed the pq-filter-search branch from db5cd7a to 4e54051 Compare May 15, 2026 15:30
This fixes commands like:
```
pq filter push --during-marker --search Paint
```

This was already possible to do this with ephemeral filters like
```
pq thread samples --during-marker --search Paint
```
@canova canova force-pushed the pq-filter-search branch from 4e54051 to 1d9998b Compare May 15, 2026 15:56
@canova canova enabled auto-merge (squash) May 19, 2026 11:04
@canova canova merged commit 73f87de into firefox-devtools:main May 19, 2026
21 checks passed
@canova canova mentioned this pull request May 26, 2026
canova added a commit that referenced this pull request May 26, 2026
Changes:

[fatadel] Remove unused dependencies from package.json (#6010)
[Nazım Can Altınova] Make profiler-cli work in sandboxed environments
(#6003)
[Markus Stange] Make profiler-edit run profile compacting before writing
out the file (#6015)
[Markus Stange] Migrate from prettier to oxfmt (#5986)
[Markus Stange] Add a --symbolicate-wasm arg to profiler-edit. (#6008)
[Markus Stange] Build and upload the cli artifact in PRs (#6020)
[Markus Stange] Use @streamparser/json if the input is too large to fit
in a V8 string (#6016)
[Nazım Can Altınova] Print also the status output right after cli `load`
command (#6019)
[Nicolas Chevobbe] Update devtools-reps to 0.27.7 (#6030)
[Nazım Can Altınova] Include `--search` option in `pq filter push`
(#6026)
[Nazım Can Altınova] Update all Yarn dependencies (2026-05-20) (#6033)
[fatadel] Translate URL track-index state through profile sanitization
(#6000)
[Markus Stange] Make withSize use a wrapper element so that it can stop
calling findDOMNode (#5988)
[Markus Stange] Fix dhat importer (#6036)
[Nazım Can Altınova] Annotate inlined frames in CLI call trees and
stacks (#6041)
[Nazım Can Altınova] Use proper types in cli tests instead of custom
inline types (#6038)
[Nazım Can Altınova] Fix text truncation for frames named after
Object.prototype methods (#6044)
[Nazım Can Altınova] Add missing key props to CodeErrorOverlay error
list items (#6047)
[depfu[bot]] ⬆️ Update oxfmt to version 0.51.0 (#6054)
[Nazım Can Altınova] 🔃 Sync: l10n -> main (May 26, 2026) (#6058)
[Nazım Can Altınova] Use URL-state symbol server for `profiler-cli
function annotate` (#6051)
[Nazım Can Altınova] Bump profiler-cli version to 0.2.0 (#6059)

And special thanks to our localizers:

fr: YD
sr: Марко Костић (Marko Kostić)
tr: Ali Demirtaş
zh-CN: Olvcpr423
zh-CN: wxie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants