Emit order completed event after status update#258
Open
PremSharma-Intelegencia wants to merge 1 commit into
Open
Emit order completed event after status update#258PremSharma-Intelegencia wants to merge 1 commit into
PremSharma-Intelegencia wants to merge 1 commit into
Conversation
Move Order::complete() so it applies the completed activity before firing the completion event. This keeps lifecycle event consumers from seeing stale order state while preserving the existing behavior that complete() emits the order completed event even when the completed activity was already applied by the caller.
PremSharma-Intelegencia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
Order::complete()so theorder.completedlifecycle event is emitted only after the order has been updated to the completed state.Previously,
notifyCompleted()was called before the completed activity/status was applied. As a result, lifecycle event consumers could receive anorder.completedevent while the order still exposed its previous status.Background
Downstream listeners build lifecycle payloads from the order state at the time the completion event is emitted.
The previous order of operations was:
This could cause stale order data to be captured by event listeners and included in webhook payloads.
Changes
notifyCompleted()after the completed activity update inOrder::complete()notifyCompleted()outside the completed-activity guard so callers that already applied the completed activity still emit the completion eventRelated PRs