Repository navigation
Conversation
The http input wrote respondsWithEmptyImg as responds_with_empty_img. in_http only knows respond_with_empty_img, so Fluentd warned that the parameter was not used and kept answering with an empty body. Signed-off-by: Lucas Barros <lucasbarros.kam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
httpPlugininapis/fluentd/v1alpha1/plugins/input/types.gorenderedhttp.respondsWithEmptyImg: trueas:Fluentd's
in_httpdeclares the option asconfig_param :respond_with_empty_img, :bool, default: false(lib/fluent/plugin/in_http.rb). The extrasmakes Fluentd logparameter 'responds_with_empty_img' in <source> is not usedand keep replying with an empty body, so clients that expect the 1x1 GIF (the reason to enable the option, e.g. tracking pixels) never get it.The rendered key is now
respond_with_empty_img. The CRD field namerespondsWithEmptyImgstays as it is, so existing resources keep working and now take effect.Test: new
apis/fluentd/v1alpha1/plugins/input/http_params_test.go. On master it fails with:and passes with this change.
go test ./apis/...andgolangci-lint run ./apis/fluentd/...pass.Which issue(s) this PR fixes:
None filed.
Does this PR introduced a user-facing change?