Skip to content

fix: add missing copyright notice to pkg/utils/dataset.go license header#6129

Open
saiashok0981 wants to merge 1 commit into
fluid-cloudnative:masterfrom
saiashok0981:dev/3
Open

fix: add missing copyright notice to pkg/utils/dataset.go license header#6129
saiashok0981 wants to merge 1 commit into
fluid-cloudnative:masterfrom
saiashok0981:dev/3

Conversation

@saiashok0981

Copy link
Copy Markdown

Description
Add the missing Copyright YEAR The Fluid Authors. line to the Apache 2.0 license header block at the top of pkg/utils/dataset.go. Every other file in the pkg/utils package includes this copyright notice, but dataset.go omitted it, leaving an incomplete license header.

Motivation
The Apache License 2.0 specification and the CNCF project conventions both require that the copyright notice appears within the file's license header block. The header in dataset.go was reduced to only the boilerplate license grant text, missing the attribution line that identifies the copyright holder. This:

Violates Apache 2.0 requirements: The license requires attribution — omitting the Copyright line makes the header legally incomplete for this file.
Inconsistent with project standards: Every other Go source file in pkg/utils/ (e.g., errors.go, quantity.go, slice.go, map.go) follows the pattern Copyright YEAR The Fluid Authors. — dataset.go is the only exception.
Fails automated license checks: Tools like licensei, addlicense, and CNCF's automated compliance scanners flag files with incomplete headers as license violations.
This is a non-functional change with zero impact on runtime behavior.

The Apache 2.0 license header in pkg/utils/dataset.go was incomplete:
it was missing the mandatory 'Copyright YEAR The Fluid Authors.' line
that appears in every other Go source file in this package.

Incomplete header (before):
  /*

  Licensed under the Apache License, Version 2.0 (the License);

Correct header (after):
  /*
  Copyright 2023 The Fluid Authors.

  Licensed under the Apache License, Version 2.0 (the License);

This omission:
  1. Violates Apache 2.0 attribution requirements (Sec. 4b requires
     preserving the copyright notice in derivative works)
  2. Is inconsistent with every other file in pkg/utils/ and across
     the entire project codebase
  3. Will be flagged by automated license compliance tools such as
     addlicense (https://github.com/google/addlicense) and licensei,
     both commonly used in CNCF projects

No functional code was changed; this is a metadata-only correction.

Signed-off-by: saiashok103@gmail.com
@fluid-e2e-bot

fluid-e2e-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zwwhdls for approval by writing /assign @zwwhdls in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot

fluid-e2e-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

Hi @saiashok0981. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a copyright header to the file pkg/utils/dataset.go. I have no further feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@cheyang

cheyang commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

@saiashok0981 — this PR is blocked from merging by a failing DCO check.
The DCO bot requires every commit to carry a Signed-off-by: trailer; without it the PR cannot land regardless of lgtm / approved labels or otherwise-green CI.

Please resolve this now. For a single-commit PR:

git commit --amend -s
git push --force-with-lease

For multiple commits on this branch:

git rebase --signoff origin/master
git push --force-with-lease

The code review side is finished and any merge labels already on the PR will take effect once DCO turns green. Reference: https://github.com/apps/dco

@cheyang

cheyang commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

/copilot review

@cheyang

cheyang commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Thanks for fixing this up. The added Copyright 2023 The Fluid Authors. line matches the header already used across the rest of pkg/utils (for example dataset_condition.go) exactly, so the fix is correct and complete. It's a metadata-only change with no functional impact, so no tests are needed here.

The one thing still blocking merge is the DCO check: the commit's Signed-off-by: trailer isn't in the required Name <email> form, so it's counted as unsigned. I left the exact fix commands in a separate comment. Once the sign-off is corrected and force-pushed this should be ready to go.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.08%. Comparing base (3e44ad2) to head (442bbb5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6129   +/-   ##
=======================================
  Coverage   65.08%   65.08%           
=======================================
  Files         485      485           
  Lines       33989    33989           
=======================================
  Hits        22122    22122           
  Misses      10126    10126           
  Partials     1741     1741           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants