Fix some little things for CI - #10000
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the unused 'test' dependency from 'devtools_app_shared/pubspec.yaml', removes the redundant 'final' keyword from a parameter in 'fake_service_extension_manager.dart', and updates 'pubspec.lock' to include the 'listen' package as a transitive dependency. There are no review comments, so no feedback is provided.
| flutter_lints: ^6.0.0 | ||
| flutter_test: | ||
| sdk: flutter | ||
| test: ^1.21.0 |
Member
There was a problem hiding this comment.
can you add a changelog entry
Contributor
Author
There was a problem hiding this comment.
This is for a dev_dependency; shouldn't affect users at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DCM discovered that devtools_app_shared no longer depends on the test package, so remove that.
Also internal analyzers are complaining about this final parameter. I think we don't get any warnings locally because the code is not versioned to Dart 3.13, where primary constructors make
finalnon-declaring parameters illegal.