Change behavior of DEVTOOLS_TOOL_FLUTTER_FROM_PATH - #10001
Open
srawlins wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the tooling scripts and Dart command runner to check if the DEVTOOLS_TOOL_FLUTTER_FROM_PATH environment variable is explicitly set to "true" instead of just checking if it is defined or non-empty. The review feedback highlights that the bash scripts (tool/bin/dt and tool/ci/setup.sh) perform case-sensitive checks, which is inconsistent with the case-insensitive checks in the batch script and Dart runner, and suggests making them case-insensitive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
DEVTOOLS_TOOL_FLUTTER_FROM_PATHvariable was treated as a "is it present or not" thing. But that could be surprising, because then a value likeDEVTOOLS_TOOL_FLUTTER_FROM_PATH=falsewould be considered... true!This changes it to a value that must be
trueorfalse.