Skip to content

Change behavior of DEVTOOLS_TOOL_FLUTTER_FROM_PATH - #10001

Open
srawlins wants to merge 1 commit into
flutter:masterfrom
srawlins:tidy-env-var
Open

Change behavior of DEVTOOLS_TOOL_FLUTTER_FROM_PATH#10001
srawlins wants to merge 1 commit into
flutter:masterfrom
srawlins:tidy-env-var

Conversation

@srawlins

@srawlins srawlins commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Previously, the DEVTOOLS_TOOL_FLUTTER_FROM_PATH variable was treated as a "is it present or not" thing. But that could be surprising, because then a value like DEVTOOLS_TOOL_FLUTTER_FROM_PATH=false would be considered... true!

This changes it to a value that must be true or false.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the tooling scripts and Dart command runner to check if the DEVTOOLS_TOOL_FLUTTER_FROM_PATH environment variable is explicitly set to "true" instead of just checking if it is defined or non-empty. The review feedback highlights that the bash scripts (tool/bin/dt and tool/ci/setup.sh) perform case-sensitive checks, which is inconsistent with the case-insensitive checks in the batch script and Dart runner, and suggests making them case-insensitive.

Comment thread tool/bin/dt
Comment thread tool/ci/setup.sh
@srawlins
srawlins requested a review from johnpryan September 3, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant