-
Notifications
You must be signed in to change notification settings - Fork 396
Reject absolute paths in devToolsFileFromPath #9844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adilburaksen
wants to merge
2
commits into
flutter:master
Choose a base branch
from
adilburaksen:fix-devtools-file-read-absolute-path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
packages/devtools_shared/test/server/file_system_test.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| // Copyright 2026 The Flutter Authors | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd. | ||
|
|
||
| import 'package:devtools_shared/src/server/file_system.dart'; | ||
| import 'package:test/test.dart'; | ||
|
|
||
| void main() { | ||
| group('LocalFileSystem.devToolsFileFromPath path validation', () { | ||
| // These inputs must be rejected before any filesystem access so that reads | ||
| // stay confined to the ~/.flutter-devtools/ directory. | ||
|
|
||
| test('rejects absolute paths', () { | ||
| // path.join() discards the base directory when its second argument is | ||
| // absolute, so an absolute path would otherwise escape the DevTools | ||
| // directory and read an arbitrary file on disk. | ||
| expect(LocalFileSystem.devToolsFileFromPath('/etc/passwd'), isNull); | ||
| expect( | ||
| LocalFileSystem.devToolsFileFromPath( | ||
| '/home/user/.config/gcloud/application_default_credentials.json', | ||
| ), | ||
| isNull, | ||
| ); | ||
| }); | ||
|
|
||
| test('rejects paths containing ".."', () { | ||
| expect(LocalFileSystem.devToolsFileFromPath('..'), isNull); | ||
| expect( | ||
| LocalFileSystem.devToolsFileFromPath('../../../etc/passwd'), | ||
| isNull, | ||
| ); | ||
| expect( | ||
| LocalFileSystem.devToolsFileFromPath('subdir/../../escape.json'), | ||
| isNull, | ||
| ); | ||
| }); | ||
| }); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[MUST-FIX] Please add automated tests to verify these security-critical path validation checks.\n\nSince this change fixes a security vulnerability (arbitrary file read via path traversal/absolute paths), it is crucial to have automated tests to prevent regressions.\n\nThe tests should cover:\n- Valid relative paths (should be allowed and return the file if it exists).\n- Absolute paths (should be rejected).\n- Path traversal attempts using
..(should be rejected).\n- Root-relative paths (e.g., starting with/or\\on Windows, which might bypasspath.isAbsolutebut should be caught bypath.isWithin).References