Repository navigation
fix(forge): keep other profiles' cached artifacts - #18461
Open
stevencartavia wants to merge 2 commits into
Open
stevencartavia wants to merge 2 commits into
stevencartavia wants to merge 2 commits into
Conversation
Symbolic runs delete cached artifacts without storage layouts so they are recompiled. Cached artifacts are scoped by source and solc version, not by compiler profile, so a filtered run could delete another profile's artifact that it never rewrites. The cache then kept pointing at the missing file and every later build recompiled. Only delete stale artifacts whose source, version, and profile this run compiles.
stevencartavia
requested review from
DaniPopes,
grandizzy and
mattsse
as code owners
November 14, 2026 04:29
mattsse
requested changes
Nov 14, 2026
mattsse
left a comment
mattsse
left a comment
Member
There was a problem hiding this comment.
The filtered compilation retry can cause a false pass in symbolic tests.
When filtered roots hit solc error 2449, the compiler retries with all source and test roots, which can select another solc version. Resolving the repair scope from the filtered roots then kept that compilation's stale artifacts, so a symbolic test could pass on artifacts without storage layouts. Resolve the scope from the roots of the compilation that produced the output and recompile those roots until no stale artifact is left.
mattsse
approved these changes
Nov 14, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symbolic runs delete cached artifacts that lack storage layouts so they get recompiled. Cached artifacts are scoped by source and solc version but not by compiler profile, so a filtered run with additional compiler profiles could delete another profile's artifact that it never rewrites, leaving the cache pointing at a missing file and making every later build recompile. This only deletes stale artifacts whose source, version, and profile the run actually compiles.