Conversation
Detect explicit io.sentry.logs.enabled Android manifest metadata and emit tailored migration warnings without changing the integration-local Logs options. Co-Authored-By: Claude <noreply@anthropic.com>
Keep parsing the nullable logs.enabled external option and emit tailored migration warnings for explicit true and false values without changing manual Logs capture. Co-Authored-By: Claude <noreply@anthropic.com>
Inspect the Spring Environment before SDK initialization and emit tailored migration warnings for explicit sentry.logs.enabled values without binding or applying the obsolete property. Co-Authored-By: Claude <noreply@anthropic.com>
Track whether the logger batch processor has accepted an item and skip empty flush and restart-close scheduling until then. This prevents SDK initialization and Android background callbacks from starting a worker thread when Logs are unused. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Aug 13, 2026
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
This was referenced Aug 13, 2026
This was referenced Aug 13, 2026
Emit legacy Logs property diagnostics after Sentry.init so the configured diagnostic logger is available. Co-Authored-By: Claude <noreply@anthropic.com>
adinauer
requested review from
0xadam-brown,
markushi,
romtsn and
runningcode
as code owners
August 13, 2026 13:41
3 of 8 tasks
runningcode
approved these changes
Aug 14, 2026
runningcode
left a comment
Contributor
There was a problem hiding this comment.
This seems like a bugfix unrelated to the stack. Can we make this an independent PR?
Closed
8 tasks
Member
Author
Before this PR stack we used noop instances to avoid the thread creation. Since we can't rely on enableLogs / enableMetrics anymore this PR is needed. It's not a separate bugfix but rather an optimization that should be part of the PR stack. |
Keep legacy Logs metadata detection compatible with both Android bundles and injected metadata maps after merging the v9 branch.
Drop the warning-only behavior so the PR is neutral before removal from the v9 stack. Co-Authored-By: Claude <noreply@anthropic.com>
# Conflicts: # sentry/src/test/java/io/sentry/ExternalOptionsTest.kt
Drop the warning-only behavior so the PR is neutral before removal from the v9 stack. Co-Authored-By: Claude <noreply@anthropic.com>
Drop the warning-only behavior so the PR is neutral before removal from the v9 stack. Co-Authored-By: Claude <noreply@anthropic.com>
adinauer
changed the base branch from
feat/warn-legacy-logs-spring
to
feat/remove-logs-enable-flag
September 30, 2026 08:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Logs and Metrics Enable Flags)
📜 Description
Tracks whether
LoggerBatchProcessorhas accepted its first Log item. Before that point, empty flushes and restart closes do not schedule processor work. Normal close still closes the executor directly.After the first accepted item, batching, flushing, and restart-close behavior remain unchanged. Items rejected because of shutdown or queue capacity do not mark the processor as used.
💡 Motivation and Context
The aggregate Logs enable flag has been removed, so every SDK client now owns a logger batch processor. Without this guard, lifecycle flushes—particularly Android background callbacks—can start a worker thread even when the application never captures a Log.
💚 How did you test it?
./gradlew :sentry:test :sentry-android-core:testReleaseUnitTest./gradlew spotlessApply apiDump📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Remove the aggregate Metrics enable flag.
#skip-changelog