feat(core): Add addConsoleInstrumentationFilter utility#20790
Merged
Conversation
We want to leverage this for Node 26 to filter deprecation messages from IITM, but this could also be used by users if they want to silence certain things.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
JPeer264
approved these changes
May 11, 2026
Member
There was a problem hiding this comment.
Overall LGTM (I btw also upvoted this: #20790 (comment))
Member
Author
|
added node-integration test, and made sure that this is properly applied in core actually instead of just in node! |
Comment on lines
14
to
24
|
|
||
| interface ConsoleIntegrationOptions { | ||
| levels: ConsoleLevel[]; | ||
| /** | ||
| * Filter out console messages that match the given strings or regular expressions. | ||
| * These will neither be passed to the handler, and they will also not be logged to the user, unless they have debug enabled. | ||
| */ | ||
| filter?: (string | RegExp)[]; | ||
| } | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
Bug: The filter option for the consoleIntegration is silently ignored in AWS Lambda environments because the Lambda-specific instrumentation bypasses the filtering logic.
Severity: MEDIUM
Suggested Fix
Modify the instrumentConsoleLambda function in packages/node-core/src/integrations/console.ts to incorporate the filter check. Before calling triggerHandlers and the original console method, evaluate the filter option. If the filter returns false, skip the instrumentation logic for that console call. This will align the Lambda environment's behavior with the standard console instrumentation.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/node-core/src/integrations/console.ts#L14-L24
Potential issue: In AWS Lambda environments, the `filter` option configured for the
`consoleIntegration` has no effect. The Lambda-specific console instrumentation wrapper,
`instrumentConsoleLambda`, directly patches console methods and calls Sentry handlers
without checking the `filter` configuration. The filtering logic exists in the core
`instrumentConsole` wrapper, but this is not used in Lambda environments. Consequently,
all console messages are processed regardless of the filter settings, potentially
leading to unwanted data being sent or processed.
Member
Author
There was a problem hiding this comment.
we'll accept this for now but I'll add a comment
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fd4296d. Configure here.
mydea
commented
May 11, 2026
| export function stringMatchesSomePattern( | ||
| testString: string, | ||
| patterns: Array<string | RegExp | ((value: string) => boolean)> = [], | ||
| patterns: |
Member
Author
There was a problem hiding this comment.
adjusted this to also accept a set, some short research showed that this is possibly slightly more performant this way anyhow (well, not that it matters I believe, but it should not hurt at least). And this means we do not need to constantly convert this from set to array in the instrumentation code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to leverage this for Node 26 to filter deprecation messages from IITM, but this could also be used by users if they want to silence certain things.
Required for #20710