feat(core): Add isTracingSuppressed to the async context strategy#21785
Open
mydea wants to merge 1 commit into
Open
feat(core): Add isTracingSuppressed to the async context strategy#21785mydea wants to merge 1 commit into
isTracingSuppressed to the async context strategy#21785mydea wants to merge 1 commit into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 620084c. Configure here.
|
|
||
| export function isTracingSuppressed(scope?: Scope): boolean { | ||
| const ctx = scope ? getContextFromScope(scope) : context.active(); | ||
| return ctx ? isTracingSuppressedImpl(ctx) : false; |
There was a problem hiding this comment.
Missing active context fallback
Medium Severity
The OpenTelemetry isTracingSuppressed helper returns false when getContextFromScope(scope) is missing, instead of falling back to context.active(). Node HTTP/fetch instrumentation now uses this path rather than checking the active OTel context directly, so suppression can be missed and outgoing spans or trace headers may still be created.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 620084c. Configure here.
Member
Author
There was a problem hiding this comment.
IMHO this is the safer approach, if that is missing.
Contributor
size-limit report 📦
|
mydea
force-pushed
the
fn/is-tracing-suppressed-acs
branch
3 times, most recently
from
07d7a16 to
d08ce0b
Compare
mydea
requested review from
JPeer264 and
andreiborza
and removed request for
a team
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Expose a public `isTracingSuppressed` helper from `@sentry/core` that delegates to the async context strategy (falling back to the scope's SDK processing metadata), mirroring how `suppressTracing` works. This lets OTel-based SDKs answer suppression from the active OpenTelemetry context rather than only the scope metadata, keeping `isTracingSuppressed` consistent with `suppressTracing`. - core: export `isTracingSuppressed`, add it to the `AsyncContextStrategy` type, and replace the private `_isTracingSuppressed` usages. - opentelemetry: implement `isTracingSuppressed` (reads the OTel context) and register it on the async context strategy. - node-core: `SentryHttpInstrumentation` and `SentryNodeFetchInstrumentation` now use core's `isTracingSuppressed()` instead of importing from `@opentelemetry/core`. - Add unit tests in core and opentelemetry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
force-pushed
the
fn/is-tracing-suppressed-acs
branch
from
d08ce0b to
a2229b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes a public
isTracingSuppressedhelper from@sentry/coreand routes it through the async context strategy, mirroringsuppressTracing.Previously
isTracingSuppressedonly existed as a private helper that checked the scope's SDK processing metadata. That's correct for the core (stack) strategy, but on OTel-based SDKs (e.g. Node) tracing suppression lives on the active OpenTelemetry context — so a metadata-only check could disagree withsuppressTracing. Routing through the async context strategy keeps the two consistent across runtimes.Changes
@sentry/core: exportisTracingSuppressed, which delegates toacs.isTracingSuppressedand falls back to the scope-metadata check. AddedisTracingSuppressedto theAsyncContextStrategytype and replaced the private_isTracingSuppressedusages.@sentry/opentelemetry: implementisTracingSuppressed(reads the active OTel context) and register it on the async context strategy.@sentry/node-core:SentryHttpInstrumentationandSentryNodeFetchInstrumentationnow call core'sisTracingSuppressed()instead of importing it from@opentelemetry/core.@sentry/coreand@sentry/opentelemetry.🤖 Generated with Claude Code