fix(deno): Enable sessions for HTTP requests - #23313
Conversation
|
Hey @AG0708 thanks for your contribution. May I ask if there is an existing issue for this? But I see that the JSDoc actually says that the default is |
Deno disabled release-health sessions for incoming node:http requests even though the shared HTTP instrumentation defaults them on. Preserve the shared default and cover it with a real request regression test. Co-Authored-By: OpenAI Codex <codex@openai.com> Signed-off-by: Abhinav Gorrepati <gorrepatiabhinav1@gmail.com>
9eb32ec to
71f66dc
Compare
|
I rebased this branch onto current |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3683d10. Configure here.
| onSpanCreated: options.onIncomingSpanCreated, | ||
| onSpanEnd: options.onIncomingSpanEnd, | ||
| errorMonitor, | ||
| sessions: false, |
There was a problem hiding this comment.
Missing sessions config options
Low Severity
Enabling release-health sessions via the shared default is correct, but DenoHttpIntegrationOptions still omits sessions and sessionFlushingDelayMS, and those values are not forwarded into getHttpServerSubscriptions. Node and Bun expose both, so Deno users cannot opt out or tune the flush delay after this behavior change.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 3683d10. Configure here.
3 participants
Deno's
node:httpserver integration disabled release-health sessions eventhough the shared HTTP instrumentation enables them by default. Keeping the
shared default aligns Deno with the other server runtimes and restores session
aggregates for incoming requests when a release is configured.
Root cause
The Deno integration passed
sessions: falsewhen it subscribed to shared HTTPserver instrumentation. There is no Deno-specific duplicate instrumentation
that requires that override.
yarn lint) & (yarn test).Fixes #22888