Repository navigation
ref(typing): Narrow request.user in agent tokens, releases, notebooks and client config - #129630
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
gricha
force-pushed
the
ref/sa-oneoffs
branch
from
November 3, 2026 00:40
2e521c0 to
8fa1428
Compare
gricha
force-pushed
the
ref/sa-oneoffs
branch
from
November 3, 2026 04:03
8fa1428 to
efdaaf5
Compare
Contributor
Sentry Snapshot Testing
|
gricha
force-pushed
the
ref/sa-oneoffs
branch
from
November 3, 2026 04:41
efdaaf5 to
3fc2a5a
Compare
gricha
force-pushed
the
ref/sa-oneoffs
branch
from
November 3, 2026 19:53
3fc2a5a to
017cfdc
Compare
gricha
force-pushed
the
ref/sa-oneoffs
branch
2 times, most recently
from
November 3, 2026 20:09
761ed1e to
f5fc3be
Compare
azulus
approved these changes
Nov 3, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
gricha
force-pushed
the
ref/sa-oneoffs
branch
2 times, most recently
from
November 3, 2026 21:10
f1378bf to
957f697
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 957f697. Configure here.
gricha
force-pushed
the
ref/sa-oneoffs
branch
2 times, most recently
from
November 4, 2026 00:44
0844d0e to
2d53d6e
Compare
… and client config - resolve_minting_principal() rejects any caller with no user. A service account used to resolve to a user principal carrying its ServiceAccountId and fail later; it now gets the same "Minting requires a user principal" 403 as an anonymous caller. - Release serialization takes a RequestPrincipal; it only forwards the caller to serialize() and serialize_generic_user(), which already take one. - Notebook endpoints read the caller through acting_user_id(). - The client config is built only from Django views, so its request is typed as an HttpRequest. Drops four files from the request.user allowlist; member management and group_integration_details.py remain.
gricha
force-pushed
the
ref/sa-oneoffs
branch
from
November 4, 2026 01:15
2d53d6e to
6ba5ef9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four one-off
request.userreads, which drops their files from the allowlist (10 → 6). What's left is member management (#129638), data export (#129637) andgroup_integration_details.py(#129639); #129640 then deletes the allowlist.resolve_minting_principal()rejects any caller with no user (has_user), not justAnonymousUser. A service account used to resolve to a user principal carrying itsServiceAccountIdand fail later; it now gets the same "Minting requires a user principal" 403 as an anonymous caller. The new assertion fails without this change:RequestPrincipal. It only forwards the caller toserialize()andserialize_generic_user(), which already take one, so this is type-only.acting_user_id(); same value for users and token callers.HttpRequest. Type-only.