Skip to content

Fix handling of comments in walkSlice() - #2284

Merged
felixfontein merged 2 commits into
getsops:mainfrom
felixfontein:comment
Aug 31, 2026
Merged

Fix handling of comments in walkSlice()#2284
felixfontein merged 2 commits into
getsops:mainfrom
felixfontein:comment

Conversation

@felixfontein

Copy link
Copy Markdown
Contributor

Fixes #2281.

Comment thread sops.go Fixed
…a in walkSlice().

Signed-off-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Felix Fontein <felix@fontein.de>

@sabre1041 sabre1041 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested and verified MAC error no longer occurs

@felixfontein
felixfontein merged commit 7b6eaa3 into getsops:main Aug 31, 2026
16 checks passed
@felixfontein
felixfontein deleted the comment branch August 31, 2026 04:39
@felixfontein

Copy link
Copy Markdown
Contributor Author

@sabre1041 thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MAC mismatch decrypting a YAML/JSON sequence when encrypted_comment_regex actually encrypts a sequence comment

3 participants