Skip to content

Support requesting latest nightly with tools: nightly #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 11 commits into from
Sep 22, 2025
Merged

Support requesting latest nightly with tools: nightly #3130

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0f4529e
Enable requesting latest nightly with "tools: nightly"
henrymercer Sep 22, 2025
9e8cbee
Process nightly CI runs using `tools: nightly`
henrymercer Sep 22, 2025
67427c6
Update prepare-test docs
henrymercer Sep 22, 2025
39be66a
Add log message
henrymercer Sep 22, 2025
48017e9
Add changelog note
henrymercer Sep 22, 2025
a25c57c
Wrap API call to provide better error message
henrymercer Sep 22, 2025
79e0afb
Run local CodeQL check using linked bundle
henrymercer Sep 22, 2025
bd51630
Specify bundle URL in local bundle PR check
henrymercer Sep 22, 2025
e2e36b1
Add helper function for reserved tools values
henrymercer Sep 22, 2025
4901f54
Lint
henrymercer Sep 22, 2025
5ab5aef
Document `nightly` tools input in `action.yml`
henrymercer Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions .github/actions/prepare-test/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,37 +35,31 @@ runs:
run: |
set -e # Fail this Action if `gh release list` fails.

if [[ "$VERSION" == "linked" ]]; then
if [[ "$VERSION" == "nightly" || "$VERSION" == "nightly-latest" ]]; then
echo "tools-url=nightly" >> "$GITHUB_OUTPUT"
exit 0
elif [[ "$VERSION" == "linked" ]]; then
echo "tools-url=linked" >> "$GITHUB_OUTPUT"
exit 0
elif [[ "$VERSION" == "default" ]]; then
echo "tools-url=" >> "$GITHUB_OUTPUT"
exit 0
fi

if [[ "$VERSION" == "nightly-latest" && "$RUNNER_OS" != "Windows" ]]; then
extension="tar.zst"
else
extension="tar.gz"
fi

if [[ "$USE_ALL_PLATFORM_BUNDLE" == "true" ]]; then
artifact_name="codeql-bundle.$extension"
artifact_name="codeql-bundle.tar.gz"
elif [[ "$RUNNER_OS" == "Linux" ]]; then
artifact_name="codeql-bundle-linux64.$extension"
artifact_name="codeql-bundle-linux64.tar.gz"
elif [[ "$RUNNER_OS" == "macOS" ]]; then
artifact_name="codeql-bundle-osx64.$extension"
artifact_name="codeql-bundle-osx64.tar.gz"
elif [[ "$RUNNER_OS" == "Windows" ]]; then
artifact_name="codeql-bundle-win64.$extension"
artifact_name="codeql-bundle-win64.tar.gz"
else
Comment on lines 48 to 57
Copy link
Copy Markdown
Member

@mbg mbg Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I know off the top of my head what's prompted this change - could you explain?

Copy link
Copy Markdown
Contributor Author

@henrymercer henrymercer Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nightly latest lookup is now handled by the Action, so the condition would never be true. And if we're referring to a specific nightly, it might not have a zstd bundle. We originally added this to improve our test coverage of zstd bundles, but now that these are shipped as latest, we have enough test coverage. So it's not really worth refactoring this to determine whether the referenced nightly has a zstd bundle.

echo "::error::Unrecognized OS $RUNNER_OS"
exit 1
fi

if [[ "$VERSION" == "nightly-latest" ]]; then
tag=`gh release list --repo dsp-testing/codeql-cli-nightlies -L 1 | cut -f 3`
echo "tools-url=https://github.com/dsp-testing/codeql-cli-nightlies/releases/download/$tag/$artifact_name" >> $GITHUB_OUTPUT
elif [[ "$VERSION" == *"nightly"* ]]; then
if [[ "$VERSION" == *"nightly"* ]]; then
version=`echo "$VERSION" | sed -e 's/^.*\-//'`
echo "tools-url=https://github.com/dsp-testing/codeql-cli-nightlies/releases/download/codeql-bundle-$version/$artifact_name" >> $GITHUB_OUTPUT
elif [[ "$VERSION" == *"stable"* ]]; then
Expand Down