Java: Add tests checking the expected Maven version is fetched#19019
Merged
smowton merged 2 commits intogithub:mainfrom Mar 18, 2025
Merged
Java: Add tests checking the expected Maven version is fetched#19019smowton merged 2 commits intogithub:mainfrom
smowton merged 2 commits intogithub:mainfrom
Conversation
smowton
force-pushed
the
smowton/feature/test-maven-enforcer
branch
from
2f7fcf3 to
3a930a1
Compare
aibaars
reviewed
Mar 18, 2025
Contributor
aibaars
left a comment
aibaars
left a comment
There was a problem hiding this comment.
Looks good to me. Could you confirm that you intended to include files from the target folder?
smowton
force-pushed
the
smowton/feature/test-maven-enforcer
branch
from
3a930a1 to
ee82b00
Compare
aibaars
previously approved these changes
Mar 18, 2025
aibaars
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a maven-fetches check file to the existing maven-enforcer test, and adds two more test cases checking behaviour for different kinds of enforcement version spec.