Rust: Add reverse post-update flow steps#19106
Merged
hvitved merged 3 commits intogithub:mainfrom Mar 26, 2025
Merged
Conversation
hvitved
force-pushed
the
rust/reverse-post-update-steps
branch
from
71f86d2 to
18e55b8
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces reverse post-update flow steps to handle side effects on receivers in post-update nodes.
- Introduces a new struct MyStruct with set_data and get_data methods.
- Adds two test functions (data_out_of_call_side_effect1 and data_out_of_call_side_effect2) to verify the reverse flow steps.
- Updates main() to invoke the new test functions.
Files not reviewed (9)
- rust/ql/lib/codeql/rust/dataflow/internal/DataFlowConsistency.qll: Language not supported
- rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qll: Language not supported
- rust/ql/lib/codeql/rust/dataflow/internal/Node.qll: Language not supported
- rust/ql/lib/codeql/rust/dataflow/internal/SsaImpl.qll: Language not supported
- rust/ql/lib/codeql/rust/dataflow/internal/TaintTrackingImpl.qll: Language not supported
- rust/ql/test/library-tests/dataflow/global/inline-flow.expected: Language not supported
- rust/ql/test/library-tests/dataflow/global/viableCallable.expected: Language not supported
- rust/ql/test/library-tests/dataflow/local/DataFlowStep.expected: Language not supported
- rust/ql/test/library-tests/dataflow/taint/TaintFlowStep.expected: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
|
|
||
| impl MyStruct { | ||
| fn set_data(&mut self, n: i64) { | ||
| (*self).data = n // todo: implicit deref not yet supported |
There was a problem hiding this comment.
The assignment statement is missing a semicolon, which could cause a compile error. Please add a semicolon at the end of the assignment.
Suggested change
| (*self).data = n // todo: implicit deref not yet supported | |
| (*self).data = n; // todo: implicit deref not yet supported |
3 tasks
paldepind
reviewed
Mar 25, 2025
paldepind
reviewed
Mar 25, 2025
paldepind
requested changes
Mar 25, 2025
Contributor
paldepind
left a comment
paldepind
left a comment
There was a problem hiding this comment.
Oops, I hit the wrong button. Looks great, but I've also left two comments :)
paldepind
previously approved these changes
Mar 26, 2025
| * | ||
| * we add a reverse flow step from `[post] { foo(); &mut a}` to `[post] &mut a`, | ||
| * in order for the side-effect of `set_data` to reach `&mut a`. | ||
| */ |
Contributor
There was a problem hiding this comment.
Thanks, this comment really helps add context 🤩
hvitved
force-pushed
the
rust/reverse-post-update-steps
branch
from
28c1c9b to
f45eca7
Compare
Contributor
Author
|
Rebased to resolve merge conflict. |
paldepind
approved these changes
Mar 26, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * we add a reverse flow step from `[post] { foo(); &mut a}` to `[post] &mut a`, | ||
| * in order for the side-effect of `set_data` to reach `&mut a`. | ||
| */ | ||
| ExprCfgNode getPostUpdateReverseStep(ExprCfgNode e, boolean preservesValue) { |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds (restricted) reverse flow steps for post-update nodes. For example, in a call like
we add a flow step from
[post] { 42; &mut a}to[post] &mut ato allow for side effects on the receiver to be reach&mut a.