Skip to content

Java: Add EnumType to SimpleTypeSanitizer#19260

Merged
smowton merged 3 commits intogithub:mainfrom
smowton:smowton/feature/sanitize-enum-types
Apr 9, 2025
Merged

Java: Add EnumType to SimpleTypeSanitizer#19260
smowton merged 3 commits intogithub:mainfrom
smowton:smowton/feature/sanitize-enum-types

Conversation

@smowton
Copy link
Copy Markdown
Contributor

@smowton smowton commented Apr 9, 2025

For the same reasons as integers and other simple values, enums are probably not useful injection vectors for most purposes.

Copilot AI review requested due to automatic review settings April 9, 2025 11:14
@smowton smowton requested a review from a team as a code owner April 9, 2025 11:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • java/ql/lib/semmle/code/java/security/Sanitizers.qll: Language not supported

@github-actions github-actions Bot added the Java label Apr 9, 2025
aschackmull
aschackmull previously approved these changes Apr 9, 2025
@smowton
Copy link
Copy Markdown
Contributor Author

smowton commented Apr 9, 2025

DCA: 6x FPs removed

michaelnebel
michaelnebel previously approved these changes Apr 9, 2025
Copy link
Copy Markdown
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread java/ql/lib/change-notes/2025-04-09-enum-type-exclusion.md Outdated
Copy link
Copy Markdown
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smowton smowton merged commit cc379b5 into github:main Apr 9, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants