Conversation
IdrissRio
added
the
depends on internal PR
IdrissRio
force-pushed
the
idrissrio/vla
branch
3 times, most recently
from
9d8403e to
3ed4a8d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new predicate, isVla(), in the ArrayType class to enable detection of variable-length arrays. Key changes include:
- Creating a new table, type_is_vla.
- Adding the isVla() predicate in ArrayType.
- Updating change notes and upgrade/downgrade scripts.
Files not reviewed (4)
- cpp/downgrades/fe54db1af25b6d8a1e25f6cbeae68baf615efc87/upgrade.properties: Language not supported
- cpp/ql/lib/semmle/code/cpp/Type.qll: Language not supported
- cpp/ql/lib/semmlecode.cpp.dbscheme: Language not supported
- cpp/ql/lib/upgrades/e594389175c098d7225683d0fd8cefcc47d84bc1/upgrade.properties: Language not supported
IdrissRio
force-pushed
the
idrissrio/vla
branch
3 times, most recently
from
13eb715 to
c39dc16
Compare
jketema
reviewed
Apr 15, 2025
Contributor
jketema
left a comment
jketema
left a comment
There was a problem hiding this comment.
One comment, which will unfortunately be a bit of annoying work, otherwise LGTM.
| int decl: @stmt_vla_decl ref | ||
| ); | ||
|
|
||
| type_is_vla(unique int type_id: @type ref) |
Contributor
There was a problem hiding this comment.
This is going to be a bit painful (because you need to re-do the upgrade scripts, and possibly also the stats file), but you should be able to do the following:
Suggested change
| type_is_vla(unique int type_id: @type ref) | |
| type_is_vla(unique int type_id: @derivedtype ref) |
Contributor
Author
There was a problem hiding this comment.
Good point! 👍
I'll change that.
IdrissRio
force-pushed
the
idrissrio/vla
branch
from
a033a95 to
ae07272
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
type_is_vla.isVla, in theArrayTypeclass.