JS: Merge ES6Class to FunctionStyleClass#19356
Merged
Napalys merged 18 commits intogithub:mainfrom May 16, 2025
Merged
Conversation
Napalys
force-pushed
the
js/merge_classes
branch
from
e4ea0cc to
f1f21b4
Compare
Napalys
force-pushed
the
js/merge_classes
branch
from
f1f21b4 to
6a284ee
Compare
asgerf
reviewed
Apr 24, 2025
Applied suggestions Co-Authored-By: Asger F <316427+asgerf@users.noreply.github.com>
Napalys
force-pushed
the
js/merge_classes
branch
from
2049f6e to
c571721
Compare
…ance was implemented via prototype manipulation instead of ES6 class syntax.
…avaScript inheritance patterns
Napalys
force-pushed
the
js/merge_classes
branch
from
1120aed to
8804836
Compare
Napalys
force-pushed
the
js/merge_classes
branch
from
424d832 to
39ecf83
Compare
Napalys
force-pushed
the
js/merge_classes
branch
from
3b7a6e7 to
04429cf
Compare
Napalys
force-pushed
the
js/merge_classes
branch
3 times, most recently
from
72e194e to
f4d8f92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges handling of
ES6ClassandFunctionStyleClassclasses into a single representation, improving call graph accuracy when these patterns are mixed in codebases. This fixes incomplete analysis issues when when prototype methods are added to ES6 classes or some sort of mixture of those.The latest dca looks good, gained new call graph edges, timings look reasonable.