Skip to content

Rust: Upgrade to rust-analyzer 0.328 #21714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tausbn wants to merge 12 commits into
base: main
Choose a base branch
from
+24,551 −8,763

Rust: fix downgrade script - add missing block_expr_try_block_modifiers

f66f82c
Select commit
Loading
Failed to load commit list.
Draft

Rust: Upgrade to rust-analyzer 0.328 #21714

Rust: fix downgrade script - add missing block_expr_try_block_modifiers
f66f82c
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Apr 16, 2026 in 11s

5 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 5 configurations present on refs/heads/main were not found:

Actions workflow (csv-coverage-metrics.yml)

  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-csharp
  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-java

Actions workflow (codeql-analysis.yml)

  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:actions
  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:csharp

Actions workflow (cpp-swift-analysis.yml)

  • ❓  .github/workflows/cpp-swift-analysis.yml:CodeQL-Build

New alerts in code changed by this pull request

  • 38 warnings

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 31 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Abi
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Addressable
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ArgList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmDirSpec
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmOperand
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmOperandExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmOption
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmPiece
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmRegSpec
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AssocItemList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Attr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Callable
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Comment
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Expr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ExternItemList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.FieldList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ForBinder
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.FormatArgsArg
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.GenericArg
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.GenericArgList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.GenericParam
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.GenericParamList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ItemList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Label
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LetElse
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroCall
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroItems
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MatchArm
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MatchArmList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MatchGuard
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Meta
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Name
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ParamBase
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ParamList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ParenthesizedArgList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Pat
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Path
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PathAstNode
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PathSegment
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Rename
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.RetTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ReturnTypeSyntax
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.SourceFile
Loading
.
Redundant import, the module is already imported

Check warning on line 46 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.CfgAtom
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.CfgAttrMeta
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.CfgComposite
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.CfgMeta
Loading
.

Check warning on line 53 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.ArgList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ArrayExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ArrayRepeatExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmConst
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmOperandExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AwaitExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.BecomeExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.BinaryExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.BreakExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.CallExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Callable
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.CastExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ClosureExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Const
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ConstArg
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ContinueExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ExprStmt
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.FieldExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ForExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.FormatArgsArg
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.FormatArgsExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.IfExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.IndexExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LabelableExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LetExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LetStmt
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LiteralExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MatchArm
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MatchExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MatchGuard
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Meta
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MethodCallExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.OffsetOfExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ParenExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PathExprBase
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PrefixExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.RangeExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.RefExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ReturnExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Static
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.StmtList
Loading
.
Redundant import, the module is already imported in

Check warning on line 72 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.FormatArgsArg
Loading
.

Check warning on line 107 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Attr
Loading
.

Check warning on line 124 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.AsmSym
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroCall
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Meta
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PathAstNode
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PathTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.UseTree
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Visibility
Loading
.

Check warning on line 168 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.MacroCall
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroDef
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroRules
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TokenTreeMeta
Loading
.

Check warning on line 171 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.BlockExpr
Loading
.

Check warning on line 176 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.ArrayTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AssocTypeArg
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.CastExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Const
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ConstParam
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.DynTraitTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.FnPtrTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ForTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Impl
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ImplTraitTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.InferTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LetStmt
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.NeverTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.OffsetOfExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ParamBase
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ParenTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PathSegment
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PathTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PtrTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.RefTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.RetTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.SliceTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Static
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.StructField
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TupleField
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TupleTypeRepr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeAlias
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeArg
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeBound
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeParam
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.WherePred
Loading
.

Check warning on line 7 in rust/ql/lib/codeql/rust/elements/FormatArgsArg.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Expr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.FormatArgsArgName
Loading
.

Check warning on line 7 in rust/ql/lib/codeql/rust/elements/TryBlockModifier.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.TypeRepr
Loading
.

Check warning on line 49 in rust/ql/lib/codeql/rust/elements/internal/FormatTemplateVariableAccessConstructor.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 9 in rust/ql/lib/codeql/rust/elements/internal/generated/BlockExpr.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning generated

Redundant import, the module is already imported inside
codeql.rust.elements.StmtList
Loading
.

Check warning on line 8 in rust/ql/lib/codeql/rust/internal/Definitions.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Format
Loading
.

Check warning on line 9 in rust/ql/lib/codeql/rust/internal/Definitions.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Format
Loading
.

Check warning on line 10 in rust/ql/lib/codeql/rust/internal/Definitions.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.FormatArgsExpr
Loading
.

Check warning on line 11 in rust/ql/lib/codeql/rust/internal/Definitions.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.FormatArgsExpr
Loading
.

Check warning on line 11 in rust/ql/lib/codeql/rust/internal/Definitions.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.FormatArgsArg
Loading
.

Check warning on line 2299 in rust/ql/lib/codeql/rust/internal/PathResolution.qll

See this annotation in the file changed.

Code scanning / CodeQL

Dead code Warning

This code is never used, and it's not publicly exported.

Check warning on line 2301 in rust/ql/lib/codeql/rust/internal/PathResolution.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 2301 in rust/ql/lib/codeql/rust/internal/PathResolution.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 2301 in rust/ql/lib/codeql/rust/internal/PathResolution.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 26 in rust/ql/test/extractor-tests/generated/BlockExpr/BlockExpr.ql

See this annotation in the file changed.

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning generated test

This predicate starts with 'get' but does not return a value.

Check warning on line 30 in rust/ql/test/extractor-tests/generated/BlockExpr/BlockExpr.ql

See this annotation in the file changed.

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning generated test

This predicate starts with 'get' but does not return a value.

Check warning on line 34 in rust/ql/test/extractor-tests/generated/BlockExpr/BlockExpr.ql

See this annotation in the file changed.

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning generated test

This predicate starts with 'get' but does not return a value.