Skip to content

dotnet: Deflake session event capture #2745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devm33 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

dotnet: Deflake session event capture #2745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dotnet/test/E2E/SessionE2ETests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,13 +388,13 @@ public async Task Should_Receive_Session_Events()
// Use OnEvent to capture events dispatched during session creation.
// session.start is emitted during the session.create RPC; if the session
// weren't registered in the sessions map before the RPC, it would be dropped.
var earlyEvents = new List<SessionEvent>();
var earlyEvents = new ConcurrentQueue<SessionEvent>();
var sessionStartReceived = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
var session = await CreateSessionAsync(new SessionConfig
{
OnEvent = evt =>
{
earlyEvents.Add(evt);
earlyEvents.Enqueue(evt);
if (evt is SessionStartEvent)
sessionStartReceived.TrySetResult(true);
},
Expand Down
Loading