Update Elixir.gitignore to match modern standards - #4889
Open
rhcarvalho wants to merge 1 commit into
Open
Conversation
Update Elixir.gitignore to match the upstream template for new Elixir projects. https://github.com/elixir-lang/elixir/blob/a9021b1c8d932fd5cf2339e4536c5c9ef024003f/lib/mix/lib/mix/tasks/new.ex#L307-L331 Remove `.fetch` which was also removed upstream (elixir-lang/elixir#13871). Preserve additional patterns added in github#2132, github#2611, and github#2872, adding comments to match the style of the rest of the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Elixir.gitignore to match the upstream template for new Elixir projects.
https://github.com/elixir-lang/elixir/blob/a9021b1c8d932fd5cf2339e4536c5c9ef024003f/lib/mix/lib/mix/tasks/new.ex#L307-L331
Remove
.fetchwhich was also removed upstream (elixir-lang/elixir#13871).Preserve additional patterns added in #2132, #2611, and #2872, adding comments to match the style of the rest of the file.
Link to the application or project's homepage
https://elixir-lang.org/
Reasons for making this change
The template hasn't been updated in 8 years, and has drifted from upstream.
This addresses the small differences, while preserving additional entries contributed by the community over the years.
Links to documentation supporting these rule changes
.gitignoreproduced bymix new(the default tool for creating new projects in the Elixir ecosystem): https://github.com/elixir-lang/elixir/blob/a9021b1c8d932fd5cf2339e4536c5c9ef024003f/lib/mix/lib/mix/tasks/new.ex#L307-L331.fetchfrom.gitignoreupstream: Update .gitignore generated by 'mix new' elixir-lang/elixir#13871 (it was originally added in Updates Elixir gitignore file #2425 with the intention to match upstream).gitignoretemplate generated for new apps withmix phx.new(matches Elixir, with a few additions): https://github.com/phoenixframework/phoenix/blob/1abb125bf22610a4c38b773b537186902bc5b576/installer/templates/phx_single/gitignore.eexMerge and Approval Steps