Skip to content

fix(infrastructure): resume setup with a secret-backed origin - #285

Merged
weastler merged 3 commits into
build/hub/newfrom
weastler-resume-secret-backed-origin
Nov 18, 2026
Merged

weastler merged 3 commits into
build/hub/newfrom
weastler-resume-secret-backed-origin

Conversation

@weastler

Copy link
Copy Markdown
Contributor

Why

Sign-in setup can stop after saving desired inputs but before completing its progress file. Resuming then rejects an unchanged Key Vault-backed origin because the origin is stored as a secret reference rather than a plain input.

What changes

New sign-in progress files retain a fingerprint of unchanged inputs and the original secret references. Resume uses that evidence to recognize the saved configuration, allowing an unversioned origin or shared authentication reference to become pinned while rejecting changed pinned versions, unrelated inputs or references, and unresolved secret writes. No secret values or extra Key Vault reads are needed.

Older progress files without this evidence still stop for review if their inputs changed. Configuration behavior and completion-marker ordering are unchanged.

weastler and others added 2 commits November 17, 2026 22:17
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@weastler
weastler requested review from a team and nshki as code owners November 18, 2026 06:26
Copilot AI adaptive review requested due to automatic review settings November 18, 2026 06:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The retained fingerprint can still block valid resumes after image and deploy_hub normalization, while suffix-only Key Vault checks mistake hexadecimal secret names for pinned versions.

5 open issues
What changed in this PR

This PR improves Azure sign-in setup recovery when setup is interrupted after saving inputs that use a Key Vault-backed application origin.

Changes:

  • Records input fingerprints and original secret references as recovery evidence.
  • Recognizes permitted reference pinning while rejecting conflicting changes and unresolved writes.
  • Adds recovery and legacy-progress tests, and documents the resume behavior.
File Description
infrastructure/​README.md Documents secret-backed origin recovery and legacy-file limits.
infrastructure/​azure/​post/​progress/​index.ts Stores and validates reference-only recovery evidence.
infrastructure/​azure/​post/​progress/​index.test.ts Adds interrupted-setup, rejection, and legacy-progress coverage.

Review effort: Max (adaptive)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@weastler
weastler merged commit da3cae8 into build/hub/new Nov 18, 2026
64 of 65 checks passed
@weastler
weastler deleted the weastler-resume-secret-backed-origin branch November 18, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants