Repository navigation
fix(installer): validate authentication input partners - #286
Merged
weastler merged 1 commit intoNov 18, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The authentication and saved-input gates introduce interacting deployment, recovery, exemption, and origin-repair requirements that need cross-flow review beyond the automated approval scope.
No open issues 🎉
What changed in this PR
This PR strengthens saved-input validation in the Azure installer so incomplete authentication settings are rejected before deployment, rather than preventing Hub from starting later.
Changes:
- Validates required Copilot App settings while preserving Copilot-only setups and supported secret references.
- Requires the authentication origin and both shared keys together, preserving the sign-in setup exception for a missing origin.
- Adds validation coverage, updates installer test fixtures, and documents the requirements.
| File | Description |
|---|---|
infrastructure/README.md |
Documents authentication dependencies and Copilot-only configuration. |
infrastructure/azure/post/index.test.ts |
Updates recovery and origin-change fixtures for stricter validation. |
infrastructure/azure/install/inputs/index.ts |
Adds Copilot configuration and shared authentication checks. |
infrastructure/azure/install/inputs/index.test.ts |
Covers missing settings, invalid values, secret references, and the origin-repair exception. |
infrastructure/azure/install/index.test.ts |
Adds required shared-key references to the customization fixture. |
Review effort: Balanced (adaptive)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Saved installer inputs can pass validation even when Hub cannot start with them. Copilot App authentication can lack its organization, installation ID, or private key, and shared authentication settings can lack their required partners.
What changes
The installer now rejects incomplete Copilot App configuration and names the missing or invalid settings without printing values. Copilot-only setups still need no GitHub sign-in provider or public origin. Both supported private-key secret references remain valid, and secret-backed identity values are checked by Hub after resolution.
An authentication origin now requires both shared keys, and either shared key requires its partner and an origin. Sign-in setup keeps its existing exception for repairing a missing origin. The change only validates inputs; it does not read or change live installations.