feat(reword): support gpg signing for non-HEAD commits#2959
Merged
Conversation
guerinoni
force-pushed
the
reword-gpg
branch
4 times, most recently
from
2314d93 to
41a801a
Compare
extrawurst
reviewed
Jun 29, 2026
extrawurst
reviewed
Jun 29, 2026
extrawurst
reviewed
Jun 29, 2026
extrawurst
reviewed
Jun 29, 2026
extrawurst
requested changes
Jun 29, 2026
extrawurst
left a comment
extrawurst
left a comment
Collaborator
There was a problem hiding this comment.
thanks for helping with this. nothing major, mostly nits
Contributor
Author
Thank you, I adjusted and rebased on master. |
extrawurst
reviewed
Jul 1, 2026
extrawurst
requested changes
Jul 1, 2026
Rewording any commit older than HEAD used to fail with SignRewordNonLastCommit as soon as commit.gpgsign was enabled, because git2's rebase API has no way to sign the commits it produces. The behaviour matched neither git CLI nor user expectation, so anyone relying on signing had to drop down to the shell to fix a typo a few commits back.
Contributor
Author
|
@extrawurst fixed |
Collaborator
|
Awesome thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewording any commit older than HEAD used to fail with
SignRewordNonLastCommit as soon as commit.gpgsign was enabled, because
git2's rebase API has no way to sign the commits it produces. The
behaviour matched neither git CLI nor user expectation, so anyone
relying on signing had to drop down to the shell to fix a typo a few
commits back.
This Pull Request fixes/closes #{issue_num}.
It changes the following:
I followed the checklist:
make checkwithout errors