fix(cli): deduplicate positional help and unify error wording on files get, files delete, and models get - #33
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
copybara/988543303
branch
from
September 28, 2026 20:24
9852b3e to
f2c83e5
Compare
copybara-service
Bot
force-pushed
the
copybara/988543303
branch
4 times, most recently
from
September 28, 2026 20:47
70ad7d6 to
ba52d26
Compare
…es get`, `files delete`, and `models get` - Remove `(also accepted as an argument)` from the `file` and `model` parameter descriptions in `overlays/cli/help.yaml` now that the CLI generator appends `(or pass it as the [<flag>] argument)` automatically. - Replace `addPositionalIdentifier` with `normalizeIdentifier` in `internal/cli/custom/register.go` so `files get`, `files delete`, and `models get` use the generated positional argument wiring, error messages, and `--usage` argument descriptions while retaining `files/<id>` and `models/<id>` normalization. - Add table tests in `internal/cli/custom/custom_test.go` covering positional and flag normalization and validation errors. PiperOrigin-RevId: 989821863
copybara-service
Bot
force-pushed
the
copybara/988543303
branch
from
September 28, 2026 20:49
ba52d26 to
1fa466c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(cli): deduplicate positional help and unify error wording on
files get,files delete, andmodels get(also accepted as an argument)from thefileandmodelparameter descriptions inoverlays/cli/help.yamlnow that the CLI generator appends(or pass it as the [<flag>] argument)automatically.addPositionalIdentifierwithnormalizeIdentifierininternal/cli/custom/register.gosofiles get,files delete, andmodels getuse the generated positional argument wiring, error messages, and--usageargument descriptions while retainingfiles/<id>andmodels/<id>normalization.internal/cli/custom/custom_test.gocovering positional and flag normalization and validation errors.