fix(cli): make environments files list example runnable and normalize --path - #35
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
copybara/988564955
branch
from
September 28, 2026 21:35
bd385f5 to
e7b7eea
Compare
copybara-service
Bot
force-pushed
the
copybara/988564955
branch
2 times, most recently
from
September 28, 2026 22:26
6ebe263 to
2790e33
Compare
…ze `--path` - Add `environment` (`env_abc123`) and `path` (`src`) parameter examples for `GetEnvironmentFiles` in `overlays/cli/examples.yaml` and regenerate the CLI so `environments files list --help` no longer shows the `<value>` placeholder or the faker-synthesized `/var/mail` path. - Add `fixNestedGroupExamples` in `internal/cli/custom/register.go` so commands mounted under nested groups (like `environments files list`) render their full command path (`gemini-api environments files list`) in `Just works:` instead of only the leaf group (`gemini-api files list`). - Add `normalizeEnvironmentFilesList` in `internal/cli/custom/register.go` to strip leading `/` from `--path` (avoiding `GET .../files//var/mail` double-slash URLs when `allowReserved` path encoding is used) and optional `environments/` prefixes from `--environment`, while rejecting slash-only paths and malformed environment IDs. PiperOrigin-RevId: 989877833
copybara-service
Bot
force-pushed
the
copybara/988564955
branch
from
September 28, 2026 22:27
2790e33 to
665cc87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(cli): make
environments files listexample runnable and normalize--pathenvironment(env_abc123) andpath(src) parameter examples forGetEnvironmentFilesinoverlays/cli/examples.yamland regenerate the CLI soenvironments files list --helpno longer shows the<value>placeholder or the faker-synthesized/var/mailpath.fixNestedGroupExamplesininternal/cli/custom/register.goso commands mounted under nested groups (likeenvironments files list) render their full command path (gemini-api environments files list) inJust works:instead of only the leaf group (gemini-api files list).normalizeEnvironmentFilesListininternal/cli/custom/register.goto strip leading/from--path(avoidingGET .../files//var/maildouble-slash URLs whenallowReservedpath encoding is used) and optionalenvironments/prefixes from--environment, while rejecting slash-only paths and malformed environment IDs.