Repository navigation
fix(net): reset io_uring multiqueue state - #557
Merged
Merged
Conversation
Coverage Report for CI Build 43393239769Coverage increased (+0.1%) to 44.177%Details
Uncovered Changes
Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
<IoUring as Backend<D>>::reset() was a no-op and VirtioIoUring lacked a
reset callback, so resetting a tap::Net device backed by io_uring kept
extra multiqueue tap sockets open instead of returning to a single
active queue pair (VirtIO 1.4 Sec 5.1.9.5.6.2: "After initialization of
reset, the device MUST queue packets only on receiveq1").
Add a default VirtioIoUring::reset(&mut self) {} method, call it from
IoUring::reset(), and truncate tap_sockets to 1 while clearing
driver_feature in both VirtioIoUring::reset() and VirtioMio::reset().
Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Lencerf
force-pushed
the
fix/net-reset-ctrlq-framing
branch
from
November 13, 2026 08:26
a96bf74 to
6013a4e
Compare
Lencerf
enabled auto-merge
November 13, 2026 08:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<IoUring as Backend<D>>::reset()was a no-op andVirtioIoUringlacked a reset callback, so resetting atap::Netdevice backed byio_uringkept extra multiqueue tap sockets open instead of returning to a single active queue pair (VirtIO 1.4 Sec 5.1.9.5.6.2: "After initialization of reset, the device MUST queue packets only on receiveq1").Add a default
VirtioIoUring::reset(&mut self) {}method, call it fromIoUring::reset(), and truncatetap_socketsto1while clearingdriver_featurein bothVirtioIoUring::reset()andVirtioMio::reset().The control queue framing fix that was also in this PR is now a separate change.