Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for Post-Quantum Cryptography (PQC) Key Encapsulation Mechanisms (KEM) and Key Derivation Functions (KDF), specifically implementing ML-KEM and HKDF algorithms, alongside utilities for Merkle Tree Certificates (MTC) verification. The review feedback highlights a memory leak in 'native_crypto.cc' where an allocated 'stack' is not freed upon an early return, and missing imports for 'urllib.request' and 'base64' in 'export_to_ag.py' that will cause runtime errors. Additionally, several defensive null checks are recommended in 'MtcUtils' to prevent potential NullPointerExceptions and improve error handling.
PiperOrigin-RevId: 999405326
juergw
force-pushed
the
google3-export
branch
from
October 14, 2026 16:16
875c276 to
afb5498
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 999324197