Skip to content

Project import generated by Copybara. - #1551

Open
juergw wants to merge 1 commit into
masterfrom
google3-export
Open

juergw wants to merge 1 commit into
masterfrom
google3-export

Conversation

@juergw

@juergw juergw commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

PiperOrigin-RevId: 999324197

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Post-Quantum Cryptography (PQC) Key Encapsulation Mechanisms (KEM) and Key Derivation Functions (KDF), specifically implementing ML-KEM and HKDF algorithms, alongside utilities for Merkle Tree Certificates (MTC) verification. The review feedback highlights a memory leak in 'native_crypto.cc' where an allocated 'stack' is not freed upon an early return, and missing imports for 'urllib.request' and 'base64' in 'export_to_ag.py' that will cause runtime errors. Additionally, several defensive null checks are recommended in 'MtcUtils' to prevent potential NullPointerExceptions and improve error handling.

Comment thread common/src/jni/main/cpp/conscrypt/native_crypto.cc
Comment thread scripts/export_to_ag.py
Comment thread common/src/main/java/org/conscrypt/util/MtcUtils.java
Comment thread common/src/main/java/org/conscrypt/util/MtcUtils.java
Comment thread common/src/main/java/org/conscrypt/util/MtcUtils.java
PiperOrigin-RevId: 999405326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants