Skip to content

Change syncRemoteTask scheduled task to be a POST #3185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gbrodman merged 1 commit into from
Jul 29, 2026
+8 −1
Merged

Change syncRemoteTask scheduled task to be a POST #3185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/main/java/google/registry/config/files/tasks/cloud-scheduler-tasks-production.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@
<task>
<url><![CDATA[/_dr/task/syncRemoteCache]]></url>
<name>syncRemoteCache</name>
<method>POST</method>
<description>
Syncs remote (Valkey/Redis) EPP resource caches with changes made recently.
</description>
Expand Down
8 changes: 7 additions & 1 deletion release/builder/deployCloudSchedulerAndQueue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ type Task struct {
Timeout string `xml:"timeout"`
Schedule string `xml:"schedule"`
Name string `xml:"name"`
Method string `xml:"method"`
}

type QueuesSyncManager struct {
Expand Down Expand Up @@ -191,6 +192,11 @@ func (manager TasksSyncManager) getArgs(task Task, operationType string) []strin
var uri string
uri = fmt.Sprintf("https://%s.%s%s", service, baseDomain, strings.TrimSpace(task.URL))

method := "get"
if task.Method != "" {
method = strings.ToLower(task.Method)
}

args := []string{
"--project", projectName,
"scheduler", "jobs", operationType,
Expand All @@ -199,7 +205,7 @@ func (manager TasksSyncManager) getArgs(task Task, operationType string) []strin
"--schedule", task.Schedule,
"--uri", uri,
"--description", description,
"--http-method", "get",
"--http-method", method,
"--oidc-service-account-email", getCloudSchedulerServiceAccountEmail(),
"--oidc-token-audience", clientId,
}
Expand Down
Loading