[jicelhay]

ListDomainsAction loads every matching domain into memory before responding, which can exhaust the server's memory when listing many or large TLDs.

This caps a single request at 10,000 domains. If more than that match and no --limit of 10,000 or less is given, the action returns an error rather than a silently truncated list. Listings of up to 10,000 domains, and any request with --limit of 10,000 or less, behave as before.

The --limit help text now mentions the cap.

b/585183729

---

This change is 

[weiminyu]

@weiminyu made 1 comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on jicelhay).

---

core/src/main/java/google/registry/tools/ListDomainsCommand.java line 46 at r1 (raw file):

              + MAX_DOMAINS
              + " domains per request and returns an error if more match.")
  private int maxDomains = Integer.MAX_VALUE;

Should we change the initial value and verify user provided one if present?

Code quote:

maxDomains = Integer.MAX_VALUE