Skip to content

fix(google-apis-core): map sharingRateLimitExceeded to RateLimitError #27178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quartzmo merged 1 commit into from
Jun 22, 2026
+31 −0
Merged

fix(google-apis-core): map sharingRateLimitExceeded to RateLimitError #27178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions google-apis-core/lib/google/apis/core/api_command.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ class ApiCommand < HttpCommand
ERROR_REASON_MAPPING = {
'rateLimitExceeded' => Google::Apis::RateLimitError,
'userRateLimitExceeded' => Google::Apis::RateLimitError,
'sharingRateLimitExceeded' => Google::Apis::RateLimitError,
'projectNotLinked' => Google::Apis::ProjectNotLinkedError
}

Expand Down
30 changes: 30 additions & 0 deletions google-apis-core/spec/google/apis/core/api_command_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,36 @@
end
end

context('with a mapped error reason (sharingRateLimitExceeded)') do
let(:command) do
Google::Apis::Core::ApiCommand.new(:get, 'https://www.googleapis.com/zoo/animals')
end

before(:example) do
json = <<~JSON
{
"error": {
"errors": [
{
"domain": "global",
"reason": "sharingRateLimitExceeded",
"message": "Sharing rate limit exceeded"
}
],
"code": 403,
"message": "Sharing rate limit exceeded"
}
}
JSON
stub_request(:get, 'https://www.googleapis.com/zoo/animals')
.to_return(status: [403, 'Forbidden'], headers: { 'Content-Type' => 'application/json' }, body: json)
end

it 'should raise a RateLimitError' do
expect { command.execute(client) }.to raise_error(Google::Apis::RateLimitError)
end
end

context('with an empty error body') do
let(:command) do
Google::Apis::Core::ApiCommand.new(:get, 'https://www.googleapis.com/zoo/animals')
Expand Down
Loading