-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(spanner): drop support for python 3.9 #17043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
f446ff7
feat(scripts): Add dependency version scanner tool
chalmerlowe 256b048
perf(search): Apply bot suggestions for regex optimization and imports
chalmerlowe 1010399
refactor(benchmark): Use tempfile for unique names and safe cleanup
chalmerlowe 68f61ee
refactor(benchmark): Remove redundant directory check
chalmerlowe cc960b4
test(integration): Check exit code of subprocess in integration test
chalmerlowe a4ad9ce
test(unit): Remove redundant and brittle test_regex_patterns
chalmerlowe 2743957
test(unit): Move import yaml to top of file
chalmerlowe 47450bb
refactor(benchmark): Remove redundant directory check in main
chalmerlowe c777e44
test(unit): Remove duplicate import yaml from function
chalmerlowe 8aab801
feat(version_scanner): handle invalid format strings in config and ad…
chalmerlowe f63053c
feat(version_scanner): handle PermissionError when reading config fil…
chalmerlowe 2af97b3
feat(version_scanner): extract read_package_file and handle file errors
chalmerlowe cb29438
refactor(version_scanner): simplify target resolution and remove dupl…
chalmerlowe ea0e8be
feat(version_scanner): add format_match_for_csv helper and tests
chalmerlowe a8824af
feat(version_scanner): integrate GitHub link generation into CSV report
chalmerlowe baafb74
feat(version_scanner): default output to results directory
chalmerlowe a1cc08e
feat(version_scanner): ignore version_scanner directory during scan
chalmerlowe 3ceea9b
feat(version_scanner): broaden version regex and add case insensitivity
chalmerlowe d756c07
feat(version_scanner): strip newlines from matched strings
chalmerlowe 075d04b
feat(version_scanner): add word boundaries and truncate long context …
chalmerlowe 85e9ff5
feat(version_scanner): add console summary table
chalmerlowe 5c8f673
feat(version_scanner): add .scannerignore file support
chalmerlowe efb3331
feat(version_scanner): move ignore defaults to .scannerignore file
chalmerlowe bf39072
docs(version_scanner): add README.md
chalmerlowe 9d9ce22
docs(version_scanner): update README options and CLI help strings
chalmerlowe 14e4dcc
feat(version_scanner): set default for --github-repo
chalmerlowe 7fc03ca
feat(version_scanner): default config path to script directory
chalmerlowe f64eac4
feat(version_scanner): support case-insensitive file ignores and add …
chalmerlowe fc47dd6
feat(version_scanner): update small package list for demos
chalmerlowe 95f6f19
Merge remote-tracking branch 'origin/main' into feat/add-version-scanner
chalmerlowe 761def6
Merge branch 'origin/main' into feat/add-version-scanner
chalmerlowe 9289c8c
feat(version_scanner): add combined_version_string rule and use word …
chalmerlowe d771258
feat(scanner): add ability to detect ignore pragma
chalmerlowe bafae70
feat(scanner): move .scannerignore to script directory and update loo…
chalmerlowe 94174bb
chore(scanner): ignore repositories.bzl in scanner
chalmerlowe d652dbf
feat(scanner): add filename scanning support
chalmerlowe a1188c8
docs(scanner): update README with known issues and add binary ignores…
chalmerlowe 0a6ae92
docs(version-scanner): merge migration guide into README.md
chalmerlowe 7cdbe72
Merge branch 'main' into feat/add-version-scanner
chalmerlowe 3c13d79
feat(spanner): drop support for python 3.9
chalmerlowe 4d9cb38
fix(spanner): resolve dependency conflicts and clean up obsolete code
chalmerlowe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 20 additions & 10 deletions
30
packages/google-cloud-spanner/testing/constraints-3.10.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,20 @@ | ||
| # -*- coding: utf-8 -*- | ||
| # This constraints file is required for unit tests. | ||
| # List all library dependencies and extras in this file. | ||
| google-api-core | ||
| google-auth | ||
| grpcio | ||
| proto-plus | ||
| protobuf | ||
| # cryptography is a direct dependency of google-auth | ||
| cryptography | ||
| # This constraints file is used to check that lower bounds | ||
| # are correct in setup.py | ||
| # List all library dependencies and extras in this file, | ||
| # pinning their versions to their lower bounds. | ||
| # For example, if setup.py has "google-cloud-foo >= 1.14.0, < 2.0.0", | ||
| # then this file should have google-cloud-foo==1.14.0 | ||
| google-api-core==2.19.0 | ||
| google-cloud-core==2.0.0 | ||
| grpc-google-iam-v1==0.12.4 | ||
| proto-plus==1.22.3 | ||
| sqlparse==0.4.4 | ||
| protobuf==4.25.8 | ||
| grpc-interceptor==0.15.4 | ||
| opentelemetry-api==1.22.0 | ||
| opentelemetry-sdk==1.22.0 | ||
| opentelemetry-semantic-conventions==0.43b0 | ||
| opentelemetry-resourcedetector-gcp==1.8.0a0 | ||
| google-cloud-monitoring==2.16.0 | ||
| mmh3==4.1.0 | ||
| libcst==0.2.5 |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the minimum supported Python version is being updated to 3.10 and
packages/google-cloud-spanner/testing/constraints-3.9.txtis being removed, a correspondingconstraints-3.10.txtfile should be added. This ensures that the lowest supported runtime has a dedicated constraints file with pins matching the lower bounds defined insetup.py. Furthermore, ensure that the project's metadata insetup.py(specificallypython_requiresand Trove classifiers) is updated to reflect this change. As dropping support for a Python version is a breaking change, please ensure a minor version bump is used for this release to maintain the ability to provide patches for the previous version.References