Skip to content

fix(proto-plus): add context to TypeErrors during message manipulation #17682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guptaarima wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −2
Open

fix(proto-plus): add context to TypeErrors during message manipulation #17682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions packages/proto-plus/proto/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,13 @@ def __init__(
params[key] = pb_value

# Create the internal protocol buffer.
super().__setattr__("_pb", self._meta.pb(**params))
try:
super().__setattr__("_pb", self._meta.pb(**params))
except TypeError as ex:
raise TypeError(
f"Failed to initialize {self.__class__.__name__} due to invalid type "
f"or structure in parameters. Underlying error: {ex}"
) from ex

def _get_pb_type_from_key(self, key):
"""Given a key, return the corresponding pb_type.
Expand Down Expand Up @@ -861,7 +867,14 @@ def __setattr__(self, key, value):

# Merge in the value being set.
if pb_value is not None:
self._pb.MergeFrom(self._meta.pb(**{key: pb_value}))
try:
self._pb.MergeFrom(self._meta.pb(**{key: pb_value}))
except TypeError as ex:
raise TypeError(
f"Failed to set field '{key}' on {self.__class__.__name__} with value {value!r}. "
f"Underlying error: {ex}"
) from ex


def __getstate__(self):
"""Serialize for pickling."""
Expand Down
Loading