Skip to content

fix(auth): address concurrency crashes, state desync, and test coverage in async mTLS sessions V2 #18355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andyrzhao wants to merge 22 commits into
base: main
Choose a base branch
from
Open

fix(auth): address concurrency crashes, state desync, and test coverage in async mTLS sessions V2 #18355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
226afd4
fix: address concurrency crashes, state desynchronization, and test c…
agrawalradhika-cell Sep 10, 2026
c9ec394
Update packages/google-auth/google/auth/aio/transport/sessions.py
agrawalradhika-cell Sep 10, 2026
2f7baa5
Update packages/google-auth/google/auth/aio/transport/sessions.py
agrawalradhika-cell Sep 10, 2026
0ffd85f
fix(auth): fix fingerprint comparison on empty cached cert, catch Typ…
agrawalradhika-cell Sep 10, 2026
3675858
fix(auth): make configure_mtls_channel idempotent for repeated defaul…
agrawalradhika-cell Sep 10, 2026
5aef5c3
test(auth): make test_401_retry_raises_timeout_before_subsequent_retr…
agrawalradhika-cell Sep 10, 2026
96ec622
fix(auth): allow mTLS retry when credentials raise NotImplementedErro…
agrawalradhika-cell Sep 10, 2026
688f76f
style(auth): format with black and fix flake8 style issues
agrawalradhika-cell Sep 10, 2026
54eb0bc
test(auth): add unit test for consecutive mTLS certificate rotations
agrawalradhika-cell Sep 10, 2026
118785b
test(auth): pass mock_auth_request in cancellation test to avoid unmo…
agrawalradhika-cell Sep 10, 2026
e046760
test(auth): allow timeout_guard error message in test_401_retry_raise…
agrawalradhika-cell Sep 10, 2026
aaa4a31
fix: Patch code logic and update tests
andyrzhao Sep 12, 2026
e337199
Merge pull request #1 from andyrzhao/pr-18334
andyrzhao Sep 12, 2026
0be988d
Update packages/google-auth/google/auth/aio/transport/sessions.py
andyrzhao Sep 12, 2026
2a9838c
Update packages/google-auth/google/auth/aio/transport/sessions.py
andyrzhao Sep 12, 2026
ddf2c31
Update packages/google-auth/tests/transport/aio/test_sessions_mtls.py
andyrzhao Sep 12, 2026
449d681
Update packages/google-auth/tests/transport/aio/test_sessions_mtls.py
andyrzhao Sep 12, 2026
87d28eb
fix(auth): add type annotation and assertion for _mtls_init_task to r…
andyrzhao Sep 12, 2026
ff80fa6
fix lint
andyrzhao Sep 12, 2026
a6aa06b
fix(auth): address review findings in async mTLS session concurrency
andyrzhao Sep 13, 2026
7736b55
fix(auth): apply non-swallowing cancellation handling to close()
andyrzhao Sep 13, 2026
ab3fe1d
fix(auth): correct post-rotation refresh and close/rotation race in a…
andyrzhao Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/google-auth/google/auth/aio/transport/mtls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def _fetch_fingerprints():
cached_cert
)
else:
cached_fingerprint = None
cached_fingerprint = current_fingerprint
return cached_fingerprint, current_fingerprint

cached_fingerprint, current_cert_fingerprint = await _run_in_executor(
Expand Down
Loading
Loading