Skip to content

fix(graphql-language-service-server): pass project when caching schema files - #4618

Open
lazerg wants to merge 1 commit into
graphql:mainfrom
lazerg:fix/issue-4615-cache-schema-project
Open

lazerg wants to merge 1 commit into
graphql:mainfrom
lazerg:fix/issue-4615-cache-schema-project

Conversation

@lazerg

@lazerg lazerg commented Oct 2, 2026

Copy link
Copy Markdown

_cacheSchemaFile already has the project but called _cacheSchemaText without it, so _updateObjectTypeDefinition looked the project up again with getProjectForFile. In a multi-project config without include, that falls back to the first project, so every schema's object types were cached under it. With include set and an absolute schema path, the lookup fails and logs doesn't match any project once per schema file. Passing project through keeps schema types under the project that declared them.

Fixes #4615

@changeset-bot

changeset-bot Bot commented Oct 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f0fcafd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphql-language-service-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: lazerg / name: lazerg (f0fcafd)

@lazerg

lazerg commented Oct 8, 2026

Copy link
Copy Markdown
Author

/easycla

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[lsp-server] 🐞 _cacheSchemaFile drops the project, schema files are looked up again

1 participant