Repository navigation
chore(sync): 同步 smoke 断言修复到 main - #5
Merged
Merged
Conversation
agent-loop 在优雅关闭时调用 machine.cancel({ kind: 'disposed' })，不带
keepInbox（只有用户的停止按钮会保留待处理输入），所以未认领的页面快照会被
记成一条 canceled 的 agent/inbox/spliced。原断言假设 dsh 会用 keepInbox 保留，
与 0.2.1-rc.2 的实际行为相反，导致 test:smoke 在 main 上一直失败。
断言改为校验真实契约（恰好一条 canceled splice、removedCount=1）；信标探测在
本机已有其他 dsh 占用更早端口时，优先选择指向本次 host 的应答。
content-selection.spec.ts 每个用例都新建 SelectionWatcher 但从未 disarm。 watcher 残留的 selectionchange 监听与 debounce 定时器可能跨到 jsdom 环境销毁 之后才触发，CI 偶发报 unhandled ReferenceError: document is not defined （run #7 的 clean-install 即因此失败）。改为在 afterEach 统一 dispose。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概述 / Summary
把
omdsh-dev/dsh-browser承载分支上的 smoke 断言修复同步到main（承载分支 → main 的常规合入）。改动内容 / Changes
test:smoke改为断言 dsh 0.2.1-rc.2 的真实 dispose 语义：未认领 inbox 重启时恰好一条agent/inbox/spliced、outcome: canceled、removedCount: 1测试 / Testing
node scripts/smoke-runtime.mjs：通过pnpm run typecheck：通过pnpm run test：65 文件 / 576 用例全过pnpm run build：通过关联 / Related
omdsh-dev/dsh-browser（PR [功能汇总] fork 仓库的新增功能，后续持续追加，可随时合回主线（已兼容0.2.1-rc.3） omdsh-dev/dsh-browser#121 的 head）